Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2598313002: Use GetProfileName() for error logs in gpu_video_decode_accelerator.cc (Closed)

Created:
3 years, 12 months ago by jam39
Modified:
3 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use GetProfileName() for error logs in gpu_video_decode_accelerator.cc BUG=676022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2598313002 Cr-Commit-Position: refs/heads/master@{#442180} Committed: https://chromium.googlesource.com/chromium/src/+/1744cf485415ad3502e20aed92f249697e8fb547

Patch Set 1 #

Patch Set 2 : Use GetProfileName() to better explain logs displaying VideoCodecProfile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M content/renderer/media/gpu/rtc_video_decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/android_video_encode_accelerator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M media/gpu/vaapi_video_encode_accelerator.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
mcasas
lgtm if bots are happy
3 years, 11 months ago (2017-01-05 20:40:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598313002/1
3 years, 11 months ago (2017-01-07 20:48:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/337066)
3 years, 11 months ago (2017-01-07 20:53:49 UTC) #12
jam39
On 2017/01/07 20:53:49, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-07 20:56:47 UTC) #14
Pawel Osciak
lgtm
3 years, 11 months ago (2017-01-07 23:10:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598313002/1
3 years, 11 months ago (2017-01-08 11:21:57 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1744cf485415ad3502e20aed92f249697e8fb547
3 years, 11 months ago (2017-01-08 11:25:49 UTC) #21
jam39
On 2017/01/08 11:25:49, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-11 14:40:07 UTC) #22
mcasas
3 years, 11 months ago (2017-01-11 15:24:43 UTC) #23
Message was sent while issue was closed.
On 2017/01/11 14:40:07, jam39 wrote:
> On 2017/01/08 11:25:49, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/1744cf485415ad3502e20aed92f2...
> 
> PTAL for patchset #2. Can this code review be re-opened?

Not anymore :-)

Just make another CL with PS2 (minus changes to
media/gpu/ipc/service/gpu_video_decode_accelerator.cc )

Powered by Google App Engine
This is Rietveld 408576698