media/filters/gpu_video_decoder.cc - Issue 2598313002: Use GetProfileName() for error logs in gpu_video_decode_accelerator.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 2598313002: Use GetProfileName() for error logs in gpu_video_decode_accelerator.cc (Closed)

Patch Set: Use GetProfileName() to better explain logs displaying VideoCodecProfile. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index 723c6da03b6bb0becb79a26ce75f7d64c9be2aae..4461dab9f4ce09b1bbf4f67ea1ed4b2d3ec42fa9 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -252,7 +252,7 @@ void GpuVideoDecoder::Initialize(const VideoDecoderConfig& config,

factories_->GetVideoDecodeAcceleratorCapabilities();

if (!IsProfileSupported(capabilities, config.profile(), config.coded_size(),

config.is_encrypted())) {

- DVLOG(1) << "Unsupported profile " << config.profile()

+ DVLOG(1) << "Unsupported profile " << GetProfileName(config.profile())

<< ", unsupported coded size " << config.coded_size().ToString()

<< ", or accelerator should only be used for encrypted content. "

<< " is_encrypted: " << (config.is_encrypted() ? "yes." : "no.");