media/gpu/android_video_encode_accelerator.cc - Issue 2598313002: Use GetProfileName() for error logs in gpu_video_decode_accelerator.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/android_video_encode_accelerator.cc

Issue 2598313002: Use GetProfileName() for error logs in gpu_video_decode_accelerator.cc (Closed)

Patch Set: Use GetProfileName() to better explain logs displaying VideoCodecProfile. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/gpu/android_video_encode_accelerator.cc

diff --git a/media/gpu/android_video_encode_accelerator.cc b/media/gpu/android_video_encode_accelerator.cc

index 2e8559dd27f21814c2cf186172240a4d39d626da..cfad7faf500a218aed6944d89394b7a39acd8b74 100644

--- a/media/gpu/android_video_encode_accelerator.cc

+++ b/media/gpu/android_video_encode_accelerator.cc

@@ -156,7 +156,8 @@ bool AndroidVideoEncodeAccelerator::Initialize(

if (!(MediaCodecUtil::SupportsSetParameters() &&

format == PIXEL_FORMAT_I420)) {

- DLOG(ERROR) << "Unexpected combo: " << format << ", " << output_profile;

+ DLOG(ERROR) << "Unexpected combo: " << format << ", "

+ << GetProfileName(output_profile);

return false;

}