Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2597353002: Add callback to LevelDBWrapperImpl to allow extra operations on commit. (Closed)

Created:
4 years ago by Marijn Kruisselbrink
Modified:
3 years, 11 months ago
Reviewers:
michaeln, jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add callback to LevelDBWrapperImpl to allow extra operations on commit. Initially this callback is used to delay writing the schema version until data actually gets committed. In follow-up CLs this will also be used to store per-origin metadata. BUG=586194 Committed: https://crrev.com/910bc047d998d05615b13c256c98d71e8bc9cc4e Cr-Commit-Position: refs/heads/master@{#440861}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -18 lines) Patch
M content/browser/dom_storage/local_storage_context_mojo.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.cc View 1 2 7 chunks +28 lines, -13 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.h View 1 3 chunks +6 lines, -1 line 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/leveldb_wrapper_impl_unittest.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Marijn Kruisselbrink
3 years, 12 months ago (2016-12-28 00:34:35 UTC) #9
jam
lgtm
3 years, 12 months ago (2016-12-28 05:51:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597353002/40001
3 years, 11 months ago (2016-12-28 17:20:57 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2016-12-28 17:25:06 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:49:22 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/910bc047d998d05615b13c256c98d71e8bc9cc4e
Cr-Commit-Position: refs/heads/master@{#440861}

Powered by Google App Engine
This is Rietveld 408576698