Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 2604963002: Store per-origin metadata for localstorage. (Closed)

Created:
3 years, 11 months ago by Marijn Kruisselbrink
Modified:
3 years, 11 months ago
Reviewers:
michaeln, jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store per-origin metadata for localstorage. This stores a last-modified timestamp and bytes_used count, as well as methods to retrieve this data again later. BUG=586194 Committed: https://crrev.com/e722a7cb8ed16bb9d5e69e97f8c57fcb9d5dc65b Cr-Commit-Position: refs/heads/master@{#440976}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : delete metadata when no more data is stored for an origin #

Total comments: 1

Patch Set 4 : remove duplicate include line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -22 lines) Patch
M content/browser/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/dom_storage/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.h View 1 2 2 chunks +19 lines, -1 line 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.cc View 1 2 3 7 chunks +97 lines, -14 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 1 2 7 chunks +136 lines, -4 lines 0 comments Download
A content/browser/dom_storage/local_storage_database.proto View 1 chunk +15 lines, -0 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/leveldb_wrapper_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (22 generated)
Marijn Kruisselbrink
3 years, 11 months ago (2016-12-28 22:50:56 UTC) #15
jam
lgtm https://codereview.chromium.org/2604963002/diff/60001/content/browser/dom_storage/local_storage_context_mojo.cc File content/browser/dom_storage/local_storage_context_mojo.cc (right): https://codereview.chromium.org/2604963002/diff/60001/content/browser/dom_storage/local_storage_context_mojo.cc#newcode10 content/browser/dom_storage/local_storage_context_mojo.cc:10: #include "components/leveldb/public/cpp/util.h" nit: remove
3 years, 11 months ago (2016-12-29 16:54:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604963002/80001
3 years, 11 months ago (2016-12-29 18:50:57 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:80001)
3 years, 11 months ago (2016-12-29 19:05:34 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:54 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e722a7cb8ed16bb9d5e69e97f8c57fcb9d5dc65b
Cr-Commit-Position: refs/heads/master@{#440976}

Powered by Google App Engine
This is Rietveld 408576698