Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2607493003: Store a version number in the localstorage database. (Closed)

Created:
3 years, 12 months ago by Marijn Kruisselbrink
Modified:
3 years, 11 months ago
Reviewers:
michaeln, jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store a version number in the localstorage database. Currently an invalid version just results in not using a backing store, but in the future that will result in upgrading and/or recreating the database. BUG=586194 Committed: https://crrev.com/0f99a7ab402c63b3b8d67ddd2a4bc19610898aa5 Cr-Commit-Position: refs/heads/master@{#440857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -14 lines) Patch
M content/browser/dom_storage/local_storage_context_mojo.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.cc View 5 chunks +61 lines, -2 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 3 chunks +65 lines, -12 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Marijn Kruisselbrink
3 years, 12 months ago (2016-12-28 00:29:22 UTC) #6
jam
lgtm
3 years, 11 months ago (2016-12-28 05:49:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607493003/1
3 years, 11 months ago (2016-12-28 17:11:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 17:15:53 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:49:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f99a7ab402c63b3b8d67ddd2a4bc19610898aa5
Cr-Commit-Position: refs/heads/master@{#440857}

Powered by Google App Engine
This is Rietveld 408576698