Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 2597283002: Warn the user before redirecting to Play Store in incognito. (Closed)

Created:
4 years ago by Maria
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Warn the user before redirecting to Play Store in incognito. Ensure the warning dialog on leaving Chrome is shown in the case where the intent URL is redirected to Play Store. BUG=648530 Committed: https://crrev.com/acc73acc491707eefbb5c3c2b540c727279d34a1 Cr-Commit-Position: refs/heads/master@{#440777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Maria
4 years ago (2016-12-22 20:26:44 UTC) #2
Ted C
lgtm
3 years, 12 months ago (2016-12-27 17:27:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597283002/1
3 years, 12 months ago (2016-12-27 19:35:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 20:07:58 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acc73acc491707eefbb5c3c2b540c727279d34a1
Cr-Commit-Position: refs/heads/master@{#440777}

Powered by Google App Engine
This is Rietveld 408576698