Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 2597283002: Warn the user before redirecting to Play Store in incognito. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index 07d89145a1469c243da13dcca9053c12e9c826a8..de3fcaff044c73242cafe48863e3a390547a9fb9 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -658,9 +658,8 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
.withIsIncognito(true)
.withReferrer(SEARCH_RESULT_URL_FOR_TOM_HANKS)
.expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_ASYNC_ACTION,
- START_INCOGNITO);
+ START_INCOGNITO | START_OTHER_ACTIVITY);
- assertNull(mDelegate.startActivityIntent);
assertNull(mDelegate.getNewUrlAfterClobbering());
assertNull(mDelegate.getReferrerUrlForClobbering());
}
@@ -720,8 +719,8 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
checkUrl(INTENT_URL_WITH_JAVASCRIPT_FALLBACK_URL)
.withReferrer(SEARCH_RESULT_URL_FOR_TOM_HANKS)
.withIsIncognito(true)
- .expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
- START_OTHER_ACTIVITY);
+ .expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_ASYNC_ACTION,
+ START_INCOGNITO | START_OTHER_ACTIVITY);
Intent invokedIntent = mDelegate.startActivityIntent;
assertTrue(invokedIntent.getData().toString().startsWith("market://"));
@@ -1250,6 +1249,7 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
@Override
public void startIncognitoIntent(Intent intent, String referrerUrl, String fallbackUrl,
Tab tab, boolean needsToCloseTab, boolean proxy) {
+ startActivityIntent = intent;
startIncognitoIntentCalled = true;
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698