Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

Issue 2597283002: Warn the user before redirecting to Play Store in incognito. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
index fc69c7c95a0fb3f378c5300cbce454320634de48..3e3db3462727767ac429c20208f659ef5af79c5c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
@@ -357,8 +357,16 @@ public class ExternalNavigationHandler {
if (params.getReferrerUrl() != null) {
intent.putExtra(Intent.EXTRA_REFERRER, Uri.parse(params.getReferrerUrl()));
}
- mDelegate.startActivity(intent, false);
- return OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT;
+ if (params.isIncognito()) {
+ mDelegate.startIncognitoIntent(intent, params.getReferrerUrl(),
+ hasBrowserFallbackUrl ? browserFallbackUrl : null, params.getTab(),
+ params.shouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent(),
+ false);
+ return OverrideUrlLoadingResult.OVERRIDE_WITH_ASYNC_ACTION;
+ } else {
+ mDelegate.startActivity(intent, false);
+ return OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT;
+ }
} catch (ActivityNotFoundException ex) {
// ignore the error on devices that does not have
// play market installed.
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698