Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2597163002: Revert of [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)

Created:
3 years, 12 months ago by Michael Hablich
Modified:
3 years, 12 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [TypeFeedbackVector] Root literal arrays in function literals slots (patchset #11 id:370001 of https://codereview.chromium.org/2504153002/ ) Reason for revert: Speculative revert because of blocked roll: https://codereview.chromium.org/2596013002/ Original issue's description: > [TypeFeedbackVector] Root literal arrays in function literals slots > > Literal arrays and feedback vectors for a function can be garbage > collected if we don't have a rooted closure for the function, which > happens often. It's expensive to come back from this (recreating > boilerplates and gathering feedback again), and the cost is > disproportionate if the function was inlined into optimized code. > > To guard against losing these arrays when we need them, we'll now > create literal arrays when creating the feedback vector for the outer > closure, and root them strongly in that vector. > > BUG=v8:5456 > > Review-Url: https://codereview.chromium.org/2504153002 > Cr-Commit-Position: refs/heads/master@{#41893} > Committed: https://chromium.googlesource.com/v8/v8/+/93df094081f04c629c3df2e40318de90ce5e0fb9 TBR=bmeurer@chromium.org,mlippautz@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5456 Review-Url: https://codereview.chromium.org/2597163002 Cr-Commit-Position: refs/heads/master@{#41917} Committed: https://chromium.googlesource.com/v8/v8/+/aa8a208a473af43e7aa97626d8d2a4a81667850c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+681 lines, -754 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ast/ast.h View 4 chunks +0 lines, -27 lines 0 comments Download
M src/ast/ast-numbering.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M src/compiler.cc View 4 chunks +21 lines, -14 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler/js-operator.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/contexts.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/contexts.cc View 6 chunks +29 lines, -10 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M src/debug/liveedit.cc View 5 chunks +33 lines, -77 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/factory.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 4 chunks +2 lines, -14 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/interface-descriptors.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 7 chunks +18 lines, -7 lines 0 comments Download
M src/objects.cc View 8 chunks +59 lines, -51 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -14 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +6 lines, -20 lines 0 comments Download
M src/type-feedback-vector.h View 10 chunks +4 lines, -44 lines 0 comments Download
M src/type-feedback-vector.cc View 11 chunks +7 lines, -82 lines 0 comments Download
M src/type-feedback-vector-inl.h View 2 chunks +1 line, -27 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 3 chunks +208 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicLoops.golden View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 18 chunks +23 lines, -23 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CompoundExpressions.golden View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextParameters.golden View 5 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextVariables.golden View 7 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CountOperators.golden View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeclareGlobals.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Delete.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/FunctionLiterals.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariableContextSlot.golden View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden View 9 chunks +23 lines, -23 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TopLevelObjectLiterals.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/strong-rooted-literals.js View 1 chunk +0 lines, -40 lines 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Revert of [TypeFeedbackVector] Root literal arrays in function literals slots
3 years, 12 months ago (2016-12-22 10:26:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597163002/1
3 years, 12 months ago (2016-12-22 10:26:12 UTC) #3
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 10:26:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/aa8a208a473af43e7aa97626d8d2a4a8166...

Powered by Google App Engine
This is Rietveld 408576698