Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/type-feedback-vector-inl.h

Issue 2597163002: Revert of [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/type-feedback-vector.cc ('k') | src/x64/interface-descriptors-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/type-feedback-vector-inl.h
diff --git a/src/type-feedback-vector-inl.h b/src/type-feedback-vector-inl.h
index c97fe4111380062e0748786e391861917cd3b365..202bd30587ca7bd8b67c339366f9b2b1e8e3fe4d 100644
--- a/src/type-feedback-vector-inl.h
+++ b/src/type-feedback-vector-inl.h
@@ -55,36 +55,11 @@
DCHECK_NE(FeedbackVectorSlotKind::KINDS_NUMBER, kind);
if (kind == FeedbackVectorSlotKind::GENERAL ||
kind == FeedbackVectorSlotKind::INTERPRETER_BINARYOP_IC ||
- kind == FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC ||
- kind == FeedbackVectorSlotKind::CREATE_CLOSURE) {
+ kind == FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC) {
return 1;
}
return 2;
-}
-
-bool TypeFeedbackMetadata::SlotRequiresParameter(FeedbackVectorSlotKind kind) {
- switch (kind) {
- case FeedbackVectorSlotKind::CREATE_CLOSURE:
- return true;
-
- case FeedbackVectorSlotKind::CALL_IC:
- case FeedbackVectorSlotKind::LOAD_IC:
- case FeedbackVectorSlotKind::LOAD_GLOBAL_IC:
- case FeedbackVectorSlotKind::KEYED_LOAD_IC:
- case FeedbackVectorSlotKind::STORE_IC:
- case FeedbackVectorSlotKind::KEYED_STORE_IC:
- case FeedbackVectorSlotKind::INTERPRETER_BINARYOP_IC:
- case FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC:
- case FeedbackVectorSlotKind::GENERAL:
- case FeedbackVectorSlotKind::INVALID:
- return false;
-
- case FeedbackVectorSlotKind::KINDS_NUMBER:
- break;
- }
- UNREACHABLE();
- return false;
}
bool TypeFeedbackVector::is_empty() const {
@@ -221,7 +196,6 @@
}
break;
}
- case FeedbackVectorSlotKind::CREATE_CLOSURE:
case FeedbackVectorSlotKind::GENERAL:
break;
case FeedbackVectorSlotKind::INVALID:
« no previous file with comments | « src/type-feedback-vector.cc ('k') | src/x64/interface-descriptors-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698