Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: src/ast/ast.h

Issue 2597163002: Revert of [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index 04a74117871f0c054aad4b5d0c31a3b59e5235f7..0a4e7481810b541c263d7965fa788375383dded2 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -2575,18 +2575,6 @@
return function_type() == kAnonymousExpression;
}
LanguageMode language_mode() const;
-
- void AssignFeedbackVectorSlots(Isolate* isolate, FeedbackVectorSpec* spec,
- FeedbackVectorSlotCache* cache) {
- // The + 1 is because we need an array with room for the literals
- // as well as the feedback vector.
- literal_feedback_slot_ =
- spec->AddCreateClosureSlot(materialized_literal_count_ + 1);
- }
-
- FeedbackVectorSlot LiteralFeedbackSlot() const {
- return literal_feedback_slot_;
- }
static bool NeedsHomeObject(Expression* expr);
@@ -2755,7 +2743,6 @@
Handle<String> inferred_name_;
AstProperties ast_properties_;
int function_literal_id_;
- FeedbackVectorSlot literal_feedback_slot_;
};
// Property is used for passing information
@@ -2846,19 +2833,6 @@
public:
Handle<String> name() const { return name_->string(); }
v8::Extension* extension() const { return extension_; }
- FeedbackVectorSlot LiteralFeedbackSlot() const {
- return literal_feedback_slot_;
- }
-
- void AssignFeedbackVectorSlots(Isolate* isolate, FeedbackVectorSpec* spec,
- FeedbackVectorSlotCache* cache) {
- // 0 is a magic number here. It means we are holding the literals
- // array for a native function literal, which needs to be
- // the empty literals array.
- // TODO(mvstanton): The FeedbackVectorSlotCache can be adapted
- // to always return the same slot for this case.
- literal_feedback_slot_ = spec->AddCreateClosureSlot(0);
- }
private:
friend class AstNodeFactory;
@@ -2871,7 +2845,6 @@
const AstRawString* name_;
v8::Extension* extension_;
- FeedbackVectorSlot literal_feedback_slot_;
};
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698