Fix use-after-scope issues with incorrect usage of ManifestParser.

Fix use-after-scope issues with incorrect usage of ManifestParser.

ManifestParser accepts references to StringPiece and GURL. In one
case, the test passed inline values which went out of scope immediately,
and then the parser used the references pointing to a stack space
potentially already reused by other local variables. In other case,
string was implicitly converted to StringPiece which also went out
of scope before Parse call.

Both issues are due to the constructor taking references. It's dangerous,
and potentially should be changed.

The issue was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
TBR=mlamouri@chromium.org

Committed: https://crrev.com/9e8006ae521235d3e9bd0f05f3b445ac37066e40
Cr-Commit-Position: refs/heads/master@{#440010}

[krasin1, 2016-12-20 22:12:51]

krasin@chromium.org changed reviewers:
+ mlamouri@chromium.org

[krasin1, 2016-12-20 22:12:56]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 22:13:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 23:19:00]

Dry run: This issue passed the CQ dry run.

[krasin1, 2016-12-21 04:07:42]

Description was changed from

==========
Fix use-after-scope issues with incorrect usage of ManifestParser.

ManifestParser accepts references to StringPiece and GURL. In one
case, the test passed inline values which went out of scope immediately,
and then the parser used the references pointing to a stack space
potentially already reused by other local variables. In other case,
string was implicitly converted to StringPiece which also went out
of scope before Parse call.

Both issues are due to the constructor taking references. It's dangerous,
and potentially should be changed.

The issue was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
==========

to

==========
Fix use-after-scope issues with incorrect usage of ManifestParser.

ManifestParser accepts references to StringPiece and GURL. In one
case, the test passed inline values which went out of scope immediately,
and then the parser used the references pointing to a stack space
potentially already reused by other local variables. In other case,
string was implicitly converted to StringPiece which also went out
of scope before Parse call.

Both issues are due to the constructor taking references. It's dangerous,
and potentially should be changed.

The issue was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
TBR=mlamouri@chromium.org
==========

[krasin1, 2016-12-21 04:07:46]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-12-21 04:08:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 04:13:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482293266173220, "parent_rev":
"28af83bd4660450da3b72b9e69dbf1aec5979043", "commit_rev":
"82c56999ac375c2dc8b40863d3678a8b203cee09"}

[commit-bot: I haz the power, 2016-12-21 04:15:06]

Description was changed from

==========
Fix use-after-scope issues with incorrect usage of ManifestParser.

ManifestParser accepts references to StringPiece and GURL. In one
case, the test passed inline values which went out of scope immediately,
and then the parser used the references pointing to a stack space
potentially already reused by other local variables. In other case,
string was implicitly converted to StringPiece which also went out
of scope before Parse call.

Both issues are due to the constructor taking references. It's dangerous,
and potentially should be changed.

The issue was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
TBR=mlamouri@chromium.org
==========

to

==========
Fix use-after-scope issues with incorrect usage of ManifestParser.

ManifestParser accepts references to StringPiece and GURL. In one
case, the test passed inline values which went out of scope immediately,
and then the parser used the references pointing to a stack space
potentially already reused by other local variables. In other case,
string was implicitly converted to StringPiece which also went out
of scope before Parse call.

Both issues are due to the constructor taking references. It's dangerous,
and potentially should be changed.

The issue was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
TBR=mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2596613002
==========

[commit-bot: I haz the power, 2016-12-21 04:15:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 04:18:46]

Description was changed from

==========
Fix use-after-scope issues with incorrect usage of ManifestParser.

ManifestParser accepts references to StringPiece and GURL. In one
case, the test passed inline values which went out of scope immediately,
and then the parser used the references pointing to a stack space
potentially already reused by other local variables. In other case,
string was implicitly converted to StringPiece which also went out
of scope before Parse call.

Both issues are due to the constructor taking references. It's dangerous,
and potentially should be changed.

The issue was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
TBR=mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2596613002
==========

to

==========
Fix use-after-scope issues with incorrect usage of ManifestParser.

ManifestParser accepts references to StringPiece and GURL. In one
case, the test passed inline values which went out of scope immediately,
and then the parser used the references pointing to a stack space
potentially already reused by other local variables. In other case,
string was implicitly converted to StringPiece which also went out
of scope before Parse call.

Both issues are due to the constructor taking references. It's dangerous,
and potentially should be changed.

The issue was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
TBR=mlamouri@chromium.org

Committed: https://crrev.com/9e8006ae521235d3e9bd0f05f3b445ac37066e40
Cr-Commit-Position: refs/heads/master@{#440010}
==========

[commit-bot: I haz the power, 2016-12-21 04:18:47]

Patchset 1 (id:??) landed as
https://crrev.com/9e8006ae521235d3e9bd0f05f3b445ac37066e40
Cr-Commit-Position: refs/heads/master@{#440010}