Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2133)

Unified Diff: content/renderer/manifest/manifest_parser_unittest.cc

Issue 2596613002: Fix use-after-scope issues with incorrect usage of ManifestParser. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/manifest/manifest_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/manifest/manifest_parser_unittest.cc
diff --git a/content/renderer/manifest/manifest_parser_unittest.cc b/content/renderer/manifest/manifest_parser_unittest.cc
index a2d12554fabe47faaac556f47ac0733f2fa65d6e..6c4eab9dfe2b451e8679bed3c563cdbe73f12c14 100644
--- a/content/renderer/manifest/manifest_parser_unittest.cc
+++ b/content/renderer/manifest/manifest_parser_unittest.cc
@@ -71,9 +71,9 @@ const GURL ManifestParserTest::default_manifest_url(
TEST_F(ManifestParserTest, CrashTest) {
// Passing temporary variables should not crash.
- ManifestParser parser("{\"start_url\": \"/\"}",
- GURL("http://example.com"),
- GURL("http://example.com"));
+ const base::StringPiece json = "{\"start_url\": \"/\"}";
+ GURL url("http://example.com");
+ ManifestParser parser(json, url, url);
parser.Parse();
std::vector<ManifestDebugInfo::Error> errors;
parser.TakeErrors(&errors);
« no previous file with comments | « content/renderer/manifest/manifest_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698