Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: content/renderer/manifest/manifest_manager.cc

Issue 2596613002: Fix use-after-scope issues with incorrect usage of ManifestParser. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/manifest/manifest_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/manifest/manifest_manager.cc
diff --git a/content/renderer/manifest/manifest_manager.cc b/content/renderer/manifest/manifest_manager.cc
index d54e41a9efe28fbfe689b7dc9e599b20c6dc2a9d..b6d3b819087515bd813fc447ee166ba8c45e56e8 100644
--- a/content/renderer/manifest/manifest_manager.cc
+++ b/content/renderer/manifest/manifest_manager.cc
@@ -150,7 +150,9 @@ void ManifestManager::OnManifestFetchComplete(
}
ManifestUmaUtil::FetchSucceeded();
- ManifestParser parser(data, response.url(), document_url);
+ GURL response_url = response.url();
+ base::StringPiece data_piece(data);
+ ManifestParser parser(data_piece, response_url, document_url);
parser.Parse();
fetcher_.reset();
« no previous file with comments | « no previous file | content/renderer/manifest/manifest_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698