Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2596373002: [mojo] Fix some lint errors (Closed)

Created:
4 years ago by Luis Héctor Chávez
Modified:
4 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo] Fix some lint errors These were found while submitting another change. It's better to submit separately to avoid introducing unnecessary noise. Also ran git cl format. BUG=None TEST=git cl lint Committed: https://crrev.com/723b70d94cfd52a63e78f88e86af98a1d3e03cd8 Cr-Commit-Position: refs/heads/master@{#440490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M mojo/edk/embedder/embedder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/core.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/core.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Luis Héctor Chávez
PTAL
4 years ago (2016-12-22 19:29:05 UTC) #4
yzshen1
On 2016/12/22 19:29:05, Luis Héctor Chávez wrote: > PTAL LGTM
4 years ago (2016-12-22 20:02:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596373002/1
4 years ago (2016-12-22 20:38:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 20:43:39 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 20:45:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/723b70d94cfd52a63e78f88e86af98a1d3e03cd8
Cr-Commit-Position: refs/heads/master@{#440490}

Powered by Google App Engine
This is Rietveld 408576698