Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: mojo/edk/system/multiprocess_message_pipe_unittest.cc

Issue 2596373002: [mojo] Fix some lint errors (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/core.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/multiprocess_message_pipe_unittest.cc
diff --git a/mojo/edk/system/multiprocess_message_pipe_unittest.cc b/mojo/edk/system/multiprocess_message_pipe_unittest.cc
index aa19c6061bf78fad3260832cfb4bd68e3a6695cb..11bb4053ac625bb08e28a5ee23f79ff14a89ec96 100644
--- a/mojo/edk/system/multiprocess_message_pipe_unittest.cc
+++ b/mojo/edk/system/multiprocess_message_pipe_unittest.cc
@@ -443,7 +443,8 @@ TEST_P(MultiprocessMessagePipeTestWithPipeCount, PlatformHandlePassing) {
}
char message[128];
- sprintf(message, "hello %d", static_cast<int>(pipe_count));
+ snprintf(message, sizeof(message), "hello %d",
+ static_cast<int>(pipe_count));
ASSERT_EQ(MOJO_RESULT_OK,
MojoWriteMessage(h, message,
static_cast<uint32_t>(strlen(message)),
@@ -465,9 +466,9 @@ TEST_P(MultiprocessMessagePipeTestWithPipeCount, PlatformHandlePassing) {
#if !defined(OS_ANDROID)
INSTANTIATE_TEST_CASE_P(PipeCount,
MultiprocessMessagePipeTestWithPipeCount,
- // TODO: Re-enable the 140-pipe case when ChannelPosix
- // has support for sending lots of handles.
- testing::Values(1u, 128u/*, 140u*/));
+ // TODO(rockot): Re-enable the 140-pipe case when
+ // ChannelPosix has support for sending lots of handles.
+ testing::Values(1u, 128u /*, 140u*/));
#endif
DEFINE_TEST_CLIENT_WITH_PIPE(CheckMessagePipe, MultiprocessMessagePipeTest, h) {
@@ -997,7 +998,7 @@ DEFINE_TEST_CLIENT_WITH_PIPE(CommandDrivenClient, MultiprocessMessagePipeTest,
}
}
- for (auto& pipe: named_pipes)
+ for (auto& pipe : named_pipes)
CloseHandle(pipe.second);
return 0;
« no previous file with comments | « mojo/edk/system/core.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698