Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 2595723003: url_formatter: Update comments for clarity. (Closed)

Created:
4 years ago by Matt Giuca
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

url_formatter: Update comments for clarity. - Separate comment describing each character in the exclusion list. - Documentation for struct fields in test. Review-Url: https://codereview.chromium.org/2595723003 Cr-Commit-Position: refs/heads/master@{#471673} Committed: https://chromium.googlesource.com/chromium/src/+/7455b06b8b993933393900c6624534335d412e4b

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Rebase. #

Patch Set 4 : Converted Python function (command) into full tool script. #

Patch Set 5 : Remove IDN test case generator (for future CL). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M components/url_formatter/idn_spoof_checker.cc View 1 2 1 chunk +19 lines, -14 lines 0 comments Download
M components/url_formatter/url_formatter_unittest.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Matt Giuca
Hi Peter, I wrote this CL as a side thing while working on r440282 but ...
3 years, 10 months ago (2017-02-03 05:18:25 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/2595723003/diff/20001/components/url_formatter/url_formatter_unittest.cc File components/url_formatter/url_formatter_unittest.cc (right): https://codereview.chromium.org/2595723003/diff/20001/components/url_formatter/url_formatter_unittest.cc#newcode50 components/url_formatter/url_formatter_unittest.cc:50: // (idna_input, unicode_output, repr(unicode_allowed).lower())) You said this didn't ...
3 years, 10 months ago (2017-02-06 21:54:14 UTC) #3
jungshik at Google
On 2017/02/06 21:54:14, Peter Kasting wrote: > LGTM > > https://codereview.chromium.org/2595723003/diff/20001/components/url_formatter/url_formatter_unittest.cc > File components/url_formatter/url_formatter_unittest.cc (right): ...
3 years, 9 months ago (2017-03-10 20:33:36 UTC) #4
Matt Giuca
On 2017/03/10 20:33:36, jungshik at Google wrote: > On 2017/02/06 21:54:14, Peter Kasting wrote: > ...
3 years, 9 months ago (2017-03-14 02:17:01 UTC) #5
Matt Giuca
OK I finally got around to this. I've converted the Python function into a full ...
3 years, 7 months ago (2017-05-15 04:24:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595723003/80001
3 years, 7 months ago (2017-05-15 04:25:14 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 05:29:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7455b06b8b993933393900c66245...

Powered by Google App Engine
This is Rietveld 408576698