Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2880983002: Added a Python script in tools/ to generate IDN test cases. (Closed)

Created:
3 years, 7 months ago by Matt Giuca
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Peter Kasting
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added a Python script in tools/ to generate IDN test cases. This script takes a Unicode domain as input, and generates the test case in C++ syntax, automatically generating the IDN encoding and normalization of the domain, and converting to a C++ wide string literal. BUG=722174 Review-Url: https://codereview.chromium.org/2880983002 Cr-Commit-Position: refs/heads/master@{#472709} Committed: https://chromium.googlesource.com/chromium/src/+/ab5dea2383c21e0fe560357cd9468b19af628510

Patch Set 1 #

Patch Set 2 : Use the args given to main. #

Patch Set 3 : Minor refactor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -0 lines) Patch
M components/url_formatter/url_formatter_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A tools/security/idn_test_case_generator.py View 1 2 1 chunk +145 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (5 generated)
Matt Giuca
Spinning off from https://codereview.chromium.org/2595723003/ jshin: Because you maintain this list. Does this script look good? ...
3 years, 7 months ago (2017-05-15 04:26:24 UTC) #2
Matt Giuca
pkasting: Upgraded to reviewer for owners on the test file.
3 years, 7 months ago (2017-05-15 04:26:51 UTC) #4
Peter Kasting
unittest LGTM
3 years, 7 months ago (2017-05-15 16:53:27 UTC) #5
Matt Giuca
jshin, jschuh: Friendly ping.
3 years, 7 months ago (2017-05-17 04:19:57 UTC) #6
jungshik at Google
On 2017/05/17 04:19:57, Matt Giuca wrote: > jshin, jschuh: Friendly ping. LGTM. Thanks ! I've ...
3 years, 7 months ago (2017-05-17 22:17:33 UTC) #7
DO NOT USE (jschuh)
I guess lgtm in principle.
3 years, 7 months ago (2017-05-17 23:38:36 UTC) #8
Matt Giuca
On 2017/05/17 23:38:36, DO NOT USE (jschuh) wrote: > I guess lgtm in principle. jschuh: ...
3 years, 7 months ago (2017-05-18 05:12:54 UTC) #9
jschuh
Weird. Don't know how it used the wrong account, but lgtm again.
3 years, 7 months ago (2017-05-18 05:41:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880983002/40001
3 years, 7 months ago (2017-05-18 05:42:59 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 06:34:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ab5dea2383c21e0fe560357cd946...

Powered by Google App Engine
This is Rietveld 408576698