Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: components/url_formatter/url_formatter_unittest.cc

Issue 2595723003: url_formatter: Update comments for clarity. (Closed)
Patch Set: Remove IDN test case generator (for future CL). Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/url_formatter/idn_spoof_checker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/url_formatter/url_formatter_unittest.cc
diff --git a/components/url_formatter/url_formatter_unittest.cc b/components/url_formatter/url_formatter_unittest.cc
index 0d028b17713c84d97a0d89d99d6c86dcbae0d6e4..d4ffb3ca509e8bfd6b0d04e514375411aaf7fd10 100644
--- a/components/url_formatter/url_formatter_unittest.cc
+++ b/components/url_formatter/url_formatter_unittest.cc
@@ -27,8 +27,14 @@ using base::ASCIIToUTF16;
const size_t kNpos = base::string16::npos;
struct IDNTestCase {
+ // The IDNA/Punycode version of the domain (plain ASCII).
const char* const input;
+ // The equivalent Unicode version of the domain. Even if we expect the domain
+ // to be displayed in Punycode, this should still contain the Unicode
+ // equivalent (see |unicode_allowed|).
const wchar_t* unicode_output;
+ // Whether we expect the domain to be displayed decoded as a Unicode string
+ // (true) or in its Punycode form (false).
const bool unicode_allowed;
};
« no previous file with comments | « components/url_formatter/idn_spoof_checker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698