Add label after creating PR, refactor WPTGitHub.request

Add label after creating PR, refactor WPTGitHub.request

(4/5) This CL is based off of https://codereview.chromium.org/2583723002 and needs to be rebased once that is landed.

BUG=657117
R=qyearsley@chromium.org

Committed: https://crrev.com/d9ca5ed0dffee53dc56ee632b5259a44b4641f91
Cr-Commit-Position: refs/heads/master@{#441037}

[jeffcarp, 2016-12-21 21:31:11]

Description was changed from

==========
Add label after creating PR, refactor WPTGitHub.request
==========

to

==========
Add label after creating PR, refactor WPTGitHub.request

(4/5) This CL is based off of https://codereview.chromium.org/2583723002 and
needs to be rebased once that is landed.

BUG=
==========

[jeffcarp, 2016-12-21 21:31:27]

Description was changed from

==========
Add label after creating PR, refactor WPTGitHub.request

(4/5) This CL is based off of https://codereview.chromium.org/2583723002 and
needs to be rebased once that is landed.

BUG=
==========

to

==========
Add label after creating PR, refactor WPTGitHub.request

(4/5) This CL is based off of https://codereview.chromium.org/2583723002 and
needs to be rebased once that is landed.

BUG=657117
R=qyearsley@chromium.org
==========

[jeffcarp, 2016-12-23 01:53:47]

jeffcarp@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2016-12-28 19:39:51]

lgtm

https://codereview.chromium.org/2595143002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py (right):

https://codereview.chromium.org/2595143002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py:42: res =
opener.open(req)
Nit: Could also use request/response instead of req/res for the names.

https://codereview.chromium.org/2595143002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py:44: return
json.load(res), status_code
It might be nice to switch to use webkitpy.common.net.web.Web to make the
request since that can be replaced with a MockWeb for unit tests. What do you
think?

[jeffcarp, 2016-12-30 19:29:46]

The CQ bit was checked by jeffcarp@chromium.org

[jeffcarp, 2016-12-30 19:29:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2595143002/#ps40001
(title: "Expand abbreviated variable names")

[commit-bot: I haz the power, 2016-12-30 19:29:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 21:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483126186475130,
"parent_rev": "4dd29424fb198c1a483e97a24507e457215377b7", "commit_rev":
"69a1efa5500016b3e102747a2d3435dc0ccdb721"}

[commit-bot: I haz the power, 2016-12-30 21:18:28]

Description was changed from

==========
Add label after creating PR, refactor WPTGitHub.request

(4/5) This CL is based off of https://codereview.chromium.org/2583723002 and
needs to be rebased once that is landed.

BUG=657117
R=qyearsley@chromium.org
==========

to

==========
Add label after creating PR, refactor WPTGitHub.request

(4/5) This CL is based off of https://codereview.chromium.org/2583723002 and
needs to be rebased once that is landed.

BUG=657117
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2595143002
==========

[commit-bot: I haz the power, 2016-12-30 21:18:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-02 15:54:42]

Description was changed from

==========
Add label after creating PR, refactor WPTGitHub.request

(4/5) This CL is based off of https://codereview.chromium.org/2583723002 and
needs to be rebased once that is landed.

BUG=657117
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2595143002
==========

to

==========
Add label after creating PR, refactor WPTGitHub.request

(4/5) This CL is based off of https://codereview.chromium.org/2583723002 and
needs to be rebased once that is landed.

BUG=657117
R=qyearsley@chromium.org

Committed: https://crrev.com/d9ca5ed0dffee53dc56ee632b5259a44b4641f91
Cr-Commit-Position: refs/heads/master@{#441037}
==========

[commit-bot: I haz the power, 2017-01-02 15:54:43]

Patchset 3 (id:??) landed as
https://crrev.com/d9ca5ed0dffee53dc56ee632b5259a44b4641f91
Cr-Commit-Position: refs/heads/master@{#441037}

[jeffcarp, 2017-01-03 20:09:20]

Oops I never published my drafts from this:

https://codereview.chromium.org/2595143002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py (right):

https://codereview.chromium.org/2595143002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py:44: return
json.load(res), status_code
On 2016/12/28 at 19:39:51, qyearsley wrote:
> It might be nice to switch to use webkitpy.common.net.web.Web to make the
request since that can be replaced with a MockWeb for unit tests. What do you
think?

Sounds great, I'll do this in a follow up CL. I made a bug for it:
https://bugs.chromium.org/p/chromium/issues/detail?id=677669