Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issue 2583723002: Use LocalWPT.test_patch when filtering exportable commits (Closed)

Created:
4 years ago by jeffcarp
Modified:
4 years ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use LocalWPT.test_patch when filtering exportable commits (3/5) This CL is based off of https://codereview.chromium.org/2576353003 and needs to be rebased once that is landed. BUG=657117 R=qyearsley@chromium.org Committed: https://crrev.com/55d6439cbf7534623a716df05eb24c7b88cff3a9 Cr-Commit-Position: refs/heads/master@{#440572}

Patch Set 1 #

Patch Set 2 : Add missing constant #

Total comments: 7

Patch Set 3 : Address CL feedback #

Patch Set 4 : Add CL suggestion, need to fix unit tests #

Patch Set 5 : Fix test_exporter_unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -42 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py View 1 5 chunks +10 lines, -21 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py View 1 2 3 4 5 chunks +41 lines, -20 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
jeffcarp
4 years ago (2016-12-16 22:28:11 UTC) #2
qyearsley
https://codereview.chromium.org/2583723002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py (right): https://codereview.chromium.org/2583723002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py#newcode112 third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py:112: """Returns the expected output of a patch agains origin/master. ...
4 years ago (2016-12-22 22:04:54 UTC) #3
jeffcarp
https://codereview.chromium.org/2583723002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py (right): https://codereview.chromium.org/2583723002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py#newcode118 third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py:118: A string containing the diff the patch produced. On ...
4 years ago (2016-12-22 23:14:29 UTC) #4
qyearsley
https://codereview.chromium.org/2583723002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py (right): https://codereview.chromium.org/2583723002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py#newcode118 third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py:118: A string containing the diff the patch produced. On ...
4 years ago (2016-12-22 23:19:53 UTC) #5
jeffcarp
On 2016/12/22 at 23:19:53, qyearsley wrote: > https://codereview.chromium.org/2583723002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py > File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py (right): > > https://codereview.chromium.org/2583723002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py#newcode118 ...
4 years ago (2016-12-22 23:25:18 UTC) #6
jeffcarp
On 2016/12/22 at 23:25:18, jeffcarp wrote: > On 2016/12/22 at 23:19:53, qyearsley wrote: > > ...
4 years ago (2016-12-22 23:40:56 UTC) #7
qyearsley
On 2016/12/22 at 23:40:56, jeffcarp wrote: > On 2016/12/22 at 23:25:18, jeffcarp wrote: > > ...
4 years ago (2016-12-22 23:44:58 UTC) #10
jeffcarp
On 2016/12/22 at 23:44:58, qyearsley wrote: > On 2016/12/22 at 23:40:56, jeffcarp wrote: > > ...
4 years ago (2016-12-23 01:12:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583723002/80001
4 years ago (2016-12-23 01:12:47 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-23 01:18:22 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-23 01:22:28 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/55d6439cbf7534623a716df05eb24c7b88cff3a9
Cr-Commit-Position: refs/heads/master@{#440572}

Powered by Google App Engine
This is Rietveld 408576698