Add label after creating PR, refactor WPTGitHub.request

third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import json
 import logging
 import os
 import sys
 import urllib2
@@ skipping 12 matching lines @@
     def __init__(self, host):
         self.host = host
         self.user = self.host.environ.get('GH_USER')
         self.token = self.host.environ.get('GH_TOKEN')
 
         assert self.user and self.token, 'must have GH_USER and GH_TOKEN env vars'
 
     def auth_token(self):
         return base64.encodestring('{}:{}'.format(self.user, self.token)).strip()
 
+    def request(self, path, method, body=None):
+        assert path.startswith('/')
+        if body:
+            body = json.dumps(body)
+        opener = urllib2.build_opener(urllib2.HTTPHandler)
+        req = urllib2.Request(url=API_BASE + path, data=body)
+        req.add_header('Accept', 'application/vnd.github.v3+json')
+        req.add_header('Authorization', 'Basic {}'.format(self.auth_token()))
+        req.get_method = lambda: method
+        res = opener.open(req)

[qyearsley, 2016/12/28 19:39:51]

Nit: Could also use request/response instead of req/res for the names.

+        status_code = res.getcode()
+        return json.load(res), status_code

[qyearsley, 2016/12/28 19:39:51]

It might be nice to switch to use webkitpy.common.net.web.Web to make the
request since that can be replaced with a MockWeb for unit tests. What do you
think?

[jeffcarp, 2017/01/03 20:09:20]

Sounds great, I'll do this in a follow up CL. I made a bug for it:
https://bugs.chromium.org/p/chromium/issues/detail?id=677669

+
     def create_pr(self, local_branch_name, desc_title, body):
         """Creates a PR on GitHub.
 
         API doc: https://developer.github.com/v3/pulls/#create-a-pull-request
 
         Returns:
             A raw response object if successful, None if not.
         """
         assert local_branch_name
         assert desc_title
         assert body
 
         pr_branch_name = '{}:{}'.format(self.user, local_branch_name)
 
         # TODO(jeffcarp): CC foolip and qyearsley on all PRs for now
         # TODO(jeffcarp): add HTTP to Host and use that here
         path = '/repos/w3c/web-platform-tests/pulls'
         body = {
             "title": desc_title,
             "body": body,
             "head": pr_branch_name,
             "base": 'master',
-            "labels": [EXPORT_LABEL]
         }
-        data, status_code = self.request(path, body)
+        data, status_code = self.request(path, method='POST', body=body)
 
         if status_code != 201:
             return None
 
         return data
 
+    def add_label(self, number):
+        path = '/repos/w3c/web-platform-tests/issues/%d/labels' % number
+        body = [EXPORT_LABEL]
+        return self.request(path, method='POST', body=body)
+
     def in_flight_pull_requests(self):
         url_encoded_label = EXPORT_LABEL.replace(' ', '%20')
         path = '/search/issues?q=repo:w3c/web-platform-tests%20is:open%20type:pr%20labels:{}'.format(url_encoded_label)
-        data, status_code = self.request(path)
+        data, status_code = self.request(path, method='GET')
         if status_code == 200:
             return data['items']
         else:
             raise Exception('Non-200 status code (%s): %s' % (status_code, data))
 
-    def request(self, path, body=None):
-        assert path.startswith('/')
-
-        if body:
-            body = json.dumps(body)
-
-        req = urllib2.Request(url=API_BASE + path, data=body)
-        req.add_header('Accept', 'application/vnd.github.v3+json')
-        req.add_header('Authorization', 'Basic {}'.format(self.auth_token()))
-        res = urllib2.urlopen(req)
-        status_code = res.getcode()
-        return json.load(res), status_code
-
     def merge_pull_request(self, pull_request_number):
         path = '/repos/w3c/web-platform-tests/pulls/%d/merge' % pull_request_number
         body = {}
-        response, content = self.request(path, body)
+        response, content = self.request(path, method='PUT', body=body)
 
         if response['status'] == '200':
             return json.loads(content)
         else:
             raise Exception('PR could not be merged: %d' % pull_request_number)