clean-up and clarify CreatePlatformCanvas methods

clean-up and clarify CreatePlatformCanvas methods

Removed unused ones, and renamed for clarity some overloads that are platform specific (to make it possible to know which are used where).

BUG=675977
TBR=

Committed: https://crrev.com/47bc98adbbef3918db8d91fd0086f14582a0f2b3
Cr-Commit-Position: refs/heads/master@{#440588}

[reed1, 2016-12-21 15:36:34]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 16:09:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 16:09:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[reed1, 2016-12-21 18:45:54]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 18:46:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-12-21 19:17:31]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:18:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-12-21 19:50:36]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-12-21 19:53:22]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:53:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 20:37:55]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[reed1, 2016-12-21 20:57:08]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 20:57:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-12-21 22:18:53]

Description was changed from

==========
name the fancy createplatformcanvas methods

BUG=
==========

to

==========
clean-up and clarify CreatePlatformCanvas methods

Removed unused ones, and renamed for clarity some overloads that are platform
specific (to make it possible to know which are used where).

BUG=675977
==========

[reed1, 2016-12-21 22:19:29]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:25:56]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[reed1, 2016-12-22 13:22:59]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 13:23:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 13:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 13:52:32]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-12-22 18:35:01]

reed@google.com changed reviewers:
+ bungeman@chromium.org

[reed1, 2016-12-22 19:57:56]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 19:58:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-12-22 20:12:26]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2016-12-22 20:12:26]

lgtm

[bungeman-chromium, 2016-12-22 20:13:12]

lgtm

[reed1, 2016-12-22 21:03:47]

reed@google.com changed reviewers:
+ sadrul@chromium.org

[reed1, 2016-12-22 21:03:47]

need OWNER for ui/

just a renaming cl

[commit-bot: I haz the power, 2016-12-22 21:26:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:26:30]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-22 23:28:27]

lgtm

[reed1, 2016-12-23 03:44:37]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-12-23 03:44:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 03:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 03:50:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reed1, 2016-12-23 04:00:39]

Description was changed from

==========
clean-up and clarify CreatePlatformCanvas methods

Removed unused ones, and renamed for clarity some overloads that are platform
specific (to make it possible to know which are used where).

BUG=675977
==========

to

==========
clean-up and clarify CreatePlatformCanvas methods

Removed unused ones, and renamed for clarity some overloads that are platform
specific (to make it possible to know which are used where).

BUG=675977
TBR=
==========

[reed1, 2016-12-23 04:00:45]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-12-23 04:00:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 04:04:37]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1482465645768230,
"parent_rev": "2eea20f6b70b40c4489f0c8dc4aced33aa757fd0", "commit_rev":
"93071c3c1e1e957ec96875203b4a55f33fb466e3"}

[commit-bot: I haz the power, 2016-12-23 04:09:12]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1482465645768230,
"parent_rev": "82223055379eeae290996162a64774b0938865d8", "commit_rev":
"fa412bbc07cc0cd96ce0a0353547e765313f1ff1"}

[commit-bot: I haz the power, 2016-12-23 04:10:30]

Description was changed from

==========
clean-up and clarify CreatePlatformCanvas methods

Removed unused ones, and renamed for clarity some overloads that are platform
specific (to make it possible to know which are used where).

BUG=675977
TBR=
==========

to

==========
clean-up and clarify CreatePlatformCanvas methods

Removed unused ones, and renamed for clarity some overloads that are platform
specific (to make it possible to know which are used where).

BUG=675977
TBR=

Review-Url: https://codereview.chromium.org/2595023002
==========

[commit-bot: I haz the power, 2016-12-23 04:10:31]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-23 04:14:46]

Description was changed from

==========
clean-up and clarify CreatePlatformCanvas methods

Removed unused ones, and renamed for clarity some overloads that are platform
specific (to make it possible to know which are used where).

BUG=675977
TBR=

Review-Url: https://codereview.chromium.org/2595023002
==========

to

==========
clean-up and clarify CreatePlatformCanvas methods

Removed unused ones, and renamed for clarity some overloads that are platform
specific (to make it possible to know which are used where).

BUG=675977
TBR=

Committed: https://crrev.com/47bc98adbbef3918db8d91fd0086f14582a0f2b3
Cr-Commit-Position: refs/heads/master@{#440588}
==========

[commit-bot: I haz the power, 2016-12-23 04:14:47]

Patchset 7 (id:??) landed as
https://crrev.com/47bc98adbbef3918db8d91fd0086f14582a0f2b3
Cr-Commit-Position: refs/heads/master@{#440588}