Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2595023002: clean-up and clarify CreatePlatformCanvas methods (Closed)

Created:
4 years ago by reed1
Modified:
3 years, 12 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clean-up and clarify CreatePlatformCanvas methods Removed unused ones, and renamed for clarity some overloads that are platform specific (to make it possible to know which are used where). BUG=675977 TBR= Committed: https://crrev.com/47bc98adbbef3918db8d91fd0086f14582a0f2b3 Cr-Commit-Position: refs/heads/master@{#440588}

Patch Set 1 #

Patch Set 2 : platform fixes #

Patch Set 3 : name the fancy createplatformcanvas methods #

Patch Set 4 : name the fancy createplatformcanvas methods #

Patch Set 5 : win fix #

Patch Set 6 : another win #

Patch Set 7 : single decl of CreatePlatformCanvasWithPixels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -71 lines) Patch
M content/browser/compositor/software_output_device_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 2 3 4 5 1 chunk +6 lines, -5 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 2 3 4 5 1 chunk +6 lines, -16 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 2 3 4 5 1 chunk +6 lines, -5 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 2 3 4 5 1 chunk +6 lines, -5 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 2 3 4 5 6 3 chunks +17 lines, -28 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/blit_unittest.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M ui/surface/transport_dib_posix.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M ui/surface/transport_dib_win.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 49 (38 generated)
reed1
4 years ago (2016-12-21 22:19:29 UTC) #18
reed1
4 years ago (2016-12-22 18:35:02 UTC) #26
bungeman-skia
lgtm
4 years ago (2016-12-22 20:12:26 UTC) #30
bungeman-chromium
lgtm
4 years ago (2016-12-22 20:13:12 UTC) #31
reed1
need OWNER for ui/ just a renaming cl
4 years ago (2016-12-22 21:03:47 UTC) #33
sadrul
lgtm
4 years ago (2016-12-22 23:28:27 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595023002/120001
3 years, 12 months ago (2016-12-23 03:44:46 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/332087)
3 years, 12 months ago (2016-12-23 03:50:18 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595023002/120001
3 years, 12 months ago (2016-12-23 04:00:56 UTC) #43
commit-bot: I haz the power
Committed patchset #7 (id:120001)
3 years, 12 months ago (2016-12-23 04:10:31 UTC) #47
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 04:14:47 UTC) #49
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/47bc98adbbef3918db8d91fd0086f14582a0f2b3
Cr-Commit-Position: refs/heads/master@{#440588}

Powered by Google App Engine
This is Rietveld 408576698