Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: skia/ext/bitmap_platform_device_mac.cc

Issue 2595023002: clean-up and clarify CreatePlatformCanvas methods (Closed)
Patch Set: single decl of CreatePlatformCanvasWithPixels Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/bitmap_platform_device_cairo.cc ('k') | skia/ext/bitmap_platform_device_skia.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/bitmap_platform_device_mac.cc
diff --git a/skia/ext/bitmap_platform_device_mac.cc b/skia/ext/bitmap_platform_device_mac.cc
index bf02a89a5e1bc31b930023fba91183325c104c35..ba5f81be324398effb767e19536134eceb6798c1 100644
--- a/skia/ext/bitmap_platform_device_mac.cc
+++ b/skia/ext/bitmap_platform_device_mac.cc
@@ -260,22 +260,12 @@ SkBaseDevice* BitmapPlatformDevice::onCreateDevice(const CreateInfo& cinfo,
// PlatformCanvas impl
-std::unique_ptr<SkCanvas> CreatePlatformCanvas(CGContextRef ctx,
- int width,
- int height,
- bool is_opaque,
- OnFailureType failureType) {
- const bool do_clear = false;
- sk_sp<SkBaseDevice> dev(
- BitmapPlatformDevice::Create(ctx, width, height, is_opaque, do_clear));
- return CreateCanvas(dev, failureType);
-}
-
-std::unique_ptr<SkCanvas> CreatePlatformCanvas(int width,
- int height,
- bool is_opaque,
- uint8_t* data,
- OnFailureType failureType) {
+std::unique_ptr<SkCanvas> CreatePlatformCanvasWithPixels(
+ int width,
+ int height,
+ bool is_opaque,
+ uint8_t* data,
+ OnFailureType failureType) {
sk_sp<SkBaseDevice> dev(
BitmapPlatformDevice::CreateWithData(data, width, height, is_opaque));
return CreateCanvas(dev, failureType);
« no previous file with comments | « skia/ext/bitmap_platform_device_cairo.cc ('k') | skia/ext/bitmap_platform_device_skia.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698