skia/ext/skia_utils_mac.mm - Issue 2595023002: clean-up and clarify CreatePlatformCanvas methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/skia_utils_mac.mm

Issue 2595023002: clean-up and clarify CreatePlatformCanvas methods (Closed)

Patch Set: single decl of CreatePlatformCanvasWithPixels Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/ext/skia_utils_mac.mm

diff --git a/skia/ext/skia_utils_mac.mm b/skia/ext/skia_utils_mac.mm

index 57fb7076ba219c4b5ccefb292200c69b5d644638..e2dbb80d0de31b5a5d6d8ecd660dd04a97bc5b10 100644

--- a/skia/ext/skia_utils_mac.mm

+++ b/skia/ext/skia_utils_mac.mm

@@ -190,8 +190,8 @@ SkBitmap CGImageToSkBitmap(CGImageRef image) {

int width = CGImageGetWidth(image);

int height = CGImageGetHeight(image);

- std::unique_ptr<SkCanvas> canvas(skia::CreatePlatformCanvas(

- nullptr, width, height, false, RETURN_NULL_ON_FAILURE));

+ std::unique_ptr<SkCanvas> canvas(

+ skia::TryCreateBitmapCanvas(width, height, false));

ScopedPlatformPaint p(canvas.get());

CGContextRef context = p.GetNativeDrawingContext();

« no previous file with comments | « skia/ext/platform_canvas.h ('k') | ui/gfx/blit_unittest.cc » ('j') | no next file with comments »