Update WebAPKs even if the WebAPK start URL has no Web Manifest

Update WebAPKs even if the WebAPK start URL has no Web Manifest

This CL makes WebApkUpdateDataFetcher call back to WebApkUpdateManager on the
WebAPK's initial load regardless of whether the URL has an associated Web
Manifest.

If
- The WebAPK's start URL no longer has an associated Web Manifest or the
updated Web Manifest is not WebAPK-able
AND
- An update is needed because the WebAPK's Java code is out of date
Then a WebAPK update is requested using the data in the WebAPK's
AndroidManifest.xml

If the WebAPK's Java code is not out of date, WebApkUpdateDataFetcher is not
destroyed. The
WebApkUpdateDataFetcher will check whether the page has a WebAPK-able Web
Manifest on each subsequent page load till a WebAPK-able Web Manifest is found.
When a WebAPK-able Web Manifest is found, WebApkUpdateManager sends a WebAPK
update request if the new Web Manifest differs from the Web Manifest data
in AndroidManifest.xml

BUG=639536
TEST=WebApkDataFetcherTest.testNoWebManifest

Committed: https://crrev.com/f20ef410db15c47df68f101b8a105cbe98d0c437
Cr-Commit-Position: refs/heads/master@{#440302}

[Xi Han, 2016-12-20 20:53:03]

The CQ bit was checked by hanxi@chromium.org to run a CQ dry run

[Xi Han, 2016-12-20 20:53:23]

hanxi@chromium.org changed reviewers:
+ dominickn@chromium.org

[Xi Han, 2016-12-20 20:53:23]

Hi Dominick, I take over this CL from pkotwicz@ as well. Could you please take
another look? Thanks!

https://codereview.chromium.org/2594813002/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_update_data_fetcher.cc (right):

https://codereview.chromium.org/2594813002/diff/20001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_update_data_fetcher.cc:145: if
(data.error_code != NO_ERROR_DETECTED ||
I believe Peter splited them as two checks because the comment above doesn't
apply to the second check.

[commit-bot: I haz the power, 2016-12-20 20:54:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 21:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 21:29:49]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-12-21 02:14:32]

https://codereview.chromium.org/2594813002/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_update_data_fetcher.cc (right):

https://codereview.chromium.org/2594813002/diff/20001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_update_data_fetcher.cc:145: if
(data.error_code != NO_ERROR_DETECTED ||
On 2016/12/20 20:53:23, Xi Han wrote:
> I believe Peter splited them as two checks because the comment above doesn't
> apply to the second check.

The comment can be very easily changed to incorporate this as well. It's
preferable to having repeated code.

"Determine whether or not the manifest is WebAPK-compatible. There are 3 cases:
1. the site isn't installable.
2. the URLs in the manifest expose passwords
3. there is no manifest or the manifest is different to the one we're expecting
(in which case, we continue observing this WebContents as we may find the
manifest on a different page)"

[Xi Han, 2016-12-21 22:24:47]

Patchset #3 (id:40001) has been deleted

[Xi Han, 2016-12-21 22:25:11]

Hi Dominick, PTAL, thanks!

https://codereview.chromium.org/2594813002/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_update_data_fetcher.cc (right):

https://codereview.chromium.org/2594813002/diff/20001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_update_data_fetcher.cc:145: if
(data.error_code != NO_ERROR_DETECTED ||
On 2016/12/21 02:14:32, dominickn wrote:
> On 2016/12/20 20:53:23, Xi Han wrote:
> > I believe Peter splited them as two checks because the comment above doesn't
> > apply to the second check.
> 
> The comment can be very easily changed to incorporate this as well. It's
> preferable to having repeated code.
> 
> "Determine whether or not the manifest is WebAPK-compatible. There are 3
cases:
> 1. the site isn't installable.
> 2. the URLs in the manifest expose passwords
> 3. there is no manifest or the manifest is different to the one we're
expecting
> (in which case, we continue observing this WebContents as we may find the
> manifest on a different page)"

All right, merge them together. I re-order these checks to put the easiest
first.

[dominickn, 2016-12-21 22:53:22]

lgtm, thanks!

[Xi Han, 2016-12-22 00:23:21]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2016-12-22 00:23:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:34:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482366201537300,
"parent_rev": "ca715dd0aae5962ad78c261b2cff5a9b51eec683", "commit_rev":
"f96b1b63583673aeffd84f72e56a53470ec2e541"}

[commit-bot: I haz the power, 2016-12-22 01:34:48]

Description was changed from

==========
Update WebAPKs even if the WebAPK start URL has no Web Manifest

This CL makes WebApkUpdateDataFetcher call back to WebApkUpdateManager on the
WebAPK's initial load regardless of whether the URL has an associated Web
Manifest.

If
- The WebAPK's start URL no longer has an associated Web Manifest or the
updated Web Manifest is not WebAPK-able
AND
- An update is needed because the WebAPK's Java code is out of date
Then a WebAPK update is requested using the data in the WebAPK's
AndroidManifest.xml

If the WebAPK's Java code is not out of date, WebApkUpdateDataFetcher is not
destroyed. The
WebApkUpdateDataFetcher will check whether the page has a WebAPK-able Web
Manifest on each subsequent page load till a WebAPK-able Web Manifest is found.
When a WebAPK-able Web Manifest is found, WebApkUpdateManager sends a WebAPK
update request if the new Web Manifest differs from the Web Manifest data
in AndroidManifest.xml

BUG=639536
TEST=WebApkDataFetcherTest.testNoWebManifest
==========

to

==========
Update WebAPKs even if the WebAPK start URL has no Web Manifest

This CL makes WebApkUpdateDataFetcher call back to WebApkUpdateManager on the
WebAPK's initial load regardless of whether the URL has an associated Web
Manifest.

If
- The WebAPK's start URL no longer has an associated Web Manifest or the
updated Web Manifest is not WebAPK-able
AND
- An update is needed because the WebAPK's Java code is out of date
Then a WebAPK update is requested using the data in the WebAPK's
AndroidManifest.xml

If the WebAPK's Java code is not out of date, WebApkUpdateDataFetcher is not
destroyed. The
WebApkUpdateDataFetcher will check whether the page has a WebAPK-able Web
Manifest on each subsequent page load till a WebAPK-able Web Manifest is found.
When a WebAPK-able Web Manifest is found, WebApkUpdateManager sends a WebAPK
update request if the new Web Manifest differs from the Web Manifest data
in AndroidManifest.xml

BUG=639536
TEST=WebApkDataFetcherTest.testNoWebManifest

Review-Url: https://codereview.chromium.org/2594813002
==========

[commit-bot: I haz the power, 2016-12-22 01:34:49]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-22 01:39:31]

Description was changed from

==========
Update WebAPKs even if the WebAPK start URL has no Web Manifest

This CL makes WebApkUpdateDataFetcher call back to WebApkUpdateManager on the
WebAPK's initial load regardless of whether the URL has an associated Web
Manifest.

If
- The WebAPK's start URL no longer has an associated Web Manifest or the
updated Web Manifest is not WebAPK-able
AND
- An update is needed because the WebAPK's Java code is out of date
Then a WebAPK update is requested using the data in the WebAPK's
AndroidManifest.xml

If the WebAPK's Java code is not out of date, WebApkUpdateDataFetcher is not
destroyed. The
WebApkUpdateDataFetcher will check whether the page has a WebAPK-able Web
Manifest on each subsequent page load till a WebAPK-able Web Manifest is found.
When a WebAPK-able Web Manifest is found, WebApkUpdateManager sends a WebAPK
update request if the new Web Manifest differs from the Web Manifest data
in AndroidManifest.xml

BUG=639536
TEST=WebApkDataFetcherTest.testNoWebManifest

Review-Url: https://codereview.chromium.org/2594813002
==========

to

==========
Update WebAPKs even if the WebAPK start URL has no Web Manifest

This CL makes WebApkUpdateDataFetcher call back to WebApkUpdateManager on the
WebAPK's initial load regardless of whether the URL has an associated Web
Manifest.

If
- The WebAPK's start URL no longer has an associated Web Manifest or the
updated Web Manifest is not WebAPK-able
AND
- An update is needed because the WebAPK's Java code is out of date
Then a WebAPK update is requested using the data in the WebAPK's
AndroidManifest.xml

If the WebAPK's Java code is not out of date, WebApkUpdateDataFetcher is not
destroyed. The
WebApkUpdateDataFetcher will check whether the page has a WebAPK-able Web
Manifest on each subsequent page load till a WebAPK-able Web Manifest is found.
When a WebAPK-able Web Manifest is found, WebApkUpdateManager sends a WebAPK
update request if the new Web Manifest differs from the Web Manifest data
in AndroidManifest.xml

BUG=639536
TEST=WebApkDataFetcherTest.testNoWebManifest

Committed: https://crrev.com/f20ef410db15c47df68f101b8a105cbe98d0c437
Cr-Commit-Position: refs/heads/master@{#440302}
==========

[commit-bot: I haz the power, 2016-12-22 01:39:32]

Patchset 3 (id:??) landed as
https://crrev.com/f20ef410db15c47df68f101b8a105cbe98d0c437
Cr-Commit-Position: refs/heads/master@{#440302}