Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/android/webapk/webapk_update_data_fetcher.h

Issue 2594813002: Update WebAPKs even if the WebAPK start URL has no Web Manifest (Closed)
Patch Set: Nits. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_update_data_fetcher.h
diff --git a/chrome/browser/android/webapk/webapk_update_data_fetcher.h b/chrome/browser/android/webapk/webapk_update_data_fetcher.h
index 6bc7885f5a5d96ad75d92af2e0004670f0093f5a..03f3dac3f35a10f28e4cd857265ed563848602ff 100644
--- a/chrome/browser/android/webapk/webapk_update_data_fetcher.h
+++ b/chrome/browser/android/webapk/webapk_update_data_fetcher.h
@@ -68,6 +68,10 @@ class WebApkUpdateDataFetcher : public content::WebContentsObserver {
const std::string& best_icon_murmur2_hash,
const SkBitmap& best_icon);
+ // Called when a page has no Web Manifest or the Web Manifest is not WebAPK
+ // compatible.
+ void OnWebManifestNotWebApkCompatible();
+
// Points to the Java object.
base::android::ScopedJavaGlobalRef<jobject> java_ref_;
@@ -77,6 +81,9 @@ class WebApkUpdateDataFetcher : public content::WebContentsObserver {
// The WebAPK's Web Manifest URL that the detector is looking for.
const GURL web_manifest_url_;
+ // Whether this is the initial URL fetch.
+ bool is_initial_fetch_;
+
// The URL for which the installable data is being fetched / was last fetched.
GURL last_fetched_url_;

Powered by Google App Engine
This is Rietveld 408576698