Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java

Issue 2594813002: Update WebAPKs even if the WebAPK start URL has no Web Manifest (Closed)
Patch Set: Nits. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java
index 9a0a84ef5984f87302cd290e6a96016c74527150..5b50aa0c6a1907276204b1fa56f4e5d2906349a7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java
@@ -22,15 +22,10 @@ public class WebApkUpdateDataFetcher extends EmptyTabObserver {
/** Observes fetching of the Web Manifest. */
public interface Observer {
/**
- * Called when the Web Manifest for the initial URL load has been fetched (successfully or
- * unsuccessfully).
- * TODO(pkotwicz): Add calls to {@link #onFinishedFetchingWebManifestForInitialUrl()}.
- * @param fetchedInfo The fetched Web Manifest data. Null if the initial URL does not point
- * to a Web Manifest.
- * @param bestIconUrl The icon URL in {@link fetchedInfo#iconUrlToMurmur2HashMap()} best
- * suited for use as the launcher icon on this device.
+ * Called when the initial URL load has completed and the page has no Web Manifest or the
+ * Web Manifest is not WebAPK compatible.
*/
- void onFinishedFetchingWebManifestForInitialUrl(WebApkInfo fetchedInfo, String bestIconUrl);
+ void onWebManifestForInitialUrlNotWebApkCompatible();
/**
* Called when the Web Manifest has been successfully fetched (including on the initial URL
@@ -121,6 +116,15 @@ public class WebApkUpdateDataFetcher extends EmptyTabObserver {
mObserver.onGotManifestData(info, bestIconUrl);
}
+ /**
+ * Called when the initial URL load has completed and the page has no Web Manifest or the
+ * Web Manifest is not WebAPK compatible.
+ */
+ @CalledByNative
+ private void onWebManifestForInitialUrlNotWebApkCompatible() {
+ mObserver.onWebManifestForInitialUrlNotWebApkCompatible();
+ }
+
private native long nativeInitialize(String scope, String webManifestUrl);
private native void nativeReplaceWebContents(
long nativeWebApkUpdateDataFetcher, WebContents webContents);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698