Change sign-in dialogs to be browser modal.

Change sign-in dialogs to be browser modal.

The sign-in modal dialogs (sign-in dialog, sync confirmation dialog,
sign-in error dialog) have a lifecycle that is independent of the current
web contents. This CL changes them to be presented as browser modal dialogs
(and not web-contents modal dialogs).

There is not difference in the presentation of the sign-in dialogs,
but rather in their behavior:
* the browser modal dialogs has the focus and the user cannot interact with
the browser window before the modal dialog is dismissed.
* the browser modal dialogs are not dismissed tab navigation

Screenshots:
https://drive.google.com/open?id=0Bw1MJ8m7U5kbSHdYZ0lsdlJ2bW8
https://drive.google.com/open?id=0Bw1MJ8m7U5kbU2dOTzZGVjR1U1U

BUG=663751
Committed: https://crrev.com/4d89528f55ebdfe107f61592694272af8b362a55
Cr-Commit-Position: refs/heads/master@{#440506}

[msarda, 2016-12-22 09:12:49]

Description was changed from

==========
Change sign-in dialogs to be browser modal.

The sign-in modal dialogs (sign-in dialog, sync confirmation dialog,
sign-in error dialog) have a lifecycle that is independent of the current
web contents. This CL changes them to be presented as browser modal dialogs
(and not web-contents modal dialogs).

There is not difference in the presentation of the sign-in dialogs,
but rather in their behavior:
* the browser modal dialogs has the focus and the user cannot interact with
the browser window before the modal dialog is dismissed.
* the browser modal dialogs are not dismissed tab navigation

BUG=663751
==========

to

==========
Change sign-in dialogs to be browser modal.

The sign-in modal dialogs (sign-in dialog, sync confirmation dialog,
sign-in error dialog) have a lifecycle that is independent of the current
web contents. This CL changes them to be presented as browser modal dialogs
(and not web-contents modal dialogs).

There is not difference in the presentation of the sign-in dialogs,
but rather in their behavior:
* the browser modal dialogs has the focus and the user cannot interact with
the browser window before the modal dialog is dismissed.
* the browser modal dialogs are not dismissed tab navigation

Screenshots:
https://drive.google.com/open?id=0Bw1MJ8m7U5kbSHdYZ0lsdlJ2bW8
https://drive.google.com/open?id=0Bw1MJ8m7U5kbU2dOTzZGVjR1U1U

BUG=663751
==========

[msarda, 2016-12-22 09:15:38]

msarda@chromium.org changed reviewers:
+ anthonyvd@chromium.org, wittman@chromium.org

[msarda, 2016-12-22 09:15:39]

Please take a look.

[msarda, 2016-12-22 09:16:07]

CC+ Eli (FYI).

[msarda, 2016-12-22 10:54:44]

msarda@chromium.org changed reviewers:
- wittman@chromium.org

[msarda, 2016-12-22 10:55:09]

msarda@chromium.org changed reviewers:
+ pkasting@chromium.org

[msarda, 2016-12-22 10:55:09]

pkasting@chromium.org: Please do an owners review for this CL.

[anthonyvd, 2016-12-22 18:05:23]

lgtm

[Peter Kasting, 2016-12-22 19:22:34]

Code LGTM, but it'd be nice to be able to actually see the screenshots (see
comment on bug).

[msarda, 2016-12-22 20:41:07]

I've shared the linked screenshots with everybody at chromium.org.

[msarda, 2016-12-22 20:41:12]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2016-12-22 20:41:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 21:25:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482439272314710, "parent_rev":
"d1fb980a5560fdf12779d38e3671832738bb28f8", "commit_rev":
"13f3c7b33ea05445a059a98ea3272864bb5ba86d"}

[commit-bot: I haz the power, 2016-12-22 21:26:23]

Description was changed from

==========
Change sign-in dialogs to be browser modal.

The sign-in modal dialogs (sign-in dialog, sync confirmation dialog,
sign-in error dialog) have a lifecycle that is independent of the current
web contents. This CL changes them to be presented as browser modal dialogs
(and not web-contents modal dialogs).

There is not difference in the presentation of the sign-in dialogs,
but rather in their behavior:
* the browser modal dialogs has the focus and the user cannot interact with
the browser window before the modal dialog is dismissed.
* the browser modal dialogs are not dismissed tab navigation

Screenshots:
https://drive.google.com/open?id=0Bw1MJ8m7U5kbSHdYZ0lsdlJ2bW8
https://drive.google.com/open?id=0Bw1MJ8m7U5kbU2dOTzZGVjR1U1U

BUG=663751
==========

to

==========
Change sign-in dialogs to be browser modal.

The sign-in modal dialogs (sign-in dialog, sync confirmation dialog,
sign-in error dialog) have a lifecycle that is independent of the current
web contents. This CL changes them to be presented as browser modal dialogs
(and not web-contents modal dialogs).

There is not difference in the presentation of the sign-in dialogs,
but rather in their behavior:
* the browser modal dialogs has the focus and the user cannot interact with
the browser window before the modal dialog is dismissed.
* the browser modal dialogs are not dismissed tab navigation

Screenshots:
https://drive.google.com/open?id=0Bw1MJ8m7U5kbSHdYZ0lsdlJ2bW8
https://drive.google.com/open?id=0Bw1MJ8m7U5kbU2dOTzZGVjR1U1U

BUG=663751

Review-Url: https://codereview.chromium.org/2594353002
==========

[commit-bot: I haz the power, 2016-12-22 21:26:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 21:34:40]

Description was changed from

==========
Change sign-in dialogs to be browser modal.

The sign-in modal dialogs (sign-in dialog, sync confirmation dialog,
sign-in error dialog) have a lifecycle that is independent of the current
web contents. This CL changes them to be presented as browser modal dialogs
(and not web-contents modal dialogs).

There is not difference in the presentation of the sign-in dialogs,
but rather in their behavior:
* the browser modal dialogs has the focus and the user cannot interact with
the browser window before the modal dialog is dismissed.
* the browser modal dialogs are not dismissed tab navigation

Screenshots:
https://drive.google.com/open?id=0Bw1MJ8m7U5kbSHdYZ0lsdlJ2bW8
https://drive.google.com/open?id=0Bw1MJ8m7U5kbU2dOTzZGVjR1U1U

BUG=663751

Review-Url: https://codereview.chromium.org/2594353002
==========

to

==========
Change sign-in dialogs to be browser modal.

The sign-in modal dialogs (sign-in dialog, sync confirmation dialog,
sign-in error dialog) have a lifecycle that is independent of the current
web contents. This CL changes them to be presented as browser modal dialogs
(and not web-contents modal dialogs).

There is not difference in the presentation of the sign-in dialogs,
but rather in their behavior:
* the browser modal dialogs has the focus and the user cannot interact with
the browser window before the modal dialog is dismissed.
* the browser modal dialogs are not dismissed tab navigation

Screenshots:
https://drive.google.com/open?id=0Bw1MJ8m7U5kbSHdYZ0lsdlJ2bW8
https://drive.google.com/open?id=0Bw1MJ8m7U5kbU2dOTzZGVjR1U1U

BUG=663751

Committed: https://crrev.com/4d89528f55ebdfe107f61592694272af8b362a55
Cr-Commit-Position: refs/heads/master@{#440506}
==========

[commit-bot: I haz the power, 2016-12-22 21:34:41]

Patchset 1 (id:??) landed as
https://crrev.com/4d89528f55ebdfe107f61592694272af8b362a55
Cr-Commit-Position: refs/heads/master@{#440506}