Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4525)

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

Issue 2594353002: Change sign-in dialogs to be browser modal. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
index 4d1ef42bfb7ad51e25861cb84d2db96d4a9c3868..d4d62e36692617ec5dd80f7c22b2a9f3e9086da1 100644
--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
@@ -74,7 +74,7 @@ void SigninViewControllerDelegateViews::DeleteDelegate() {
}
ui::ModalType SigninViewControllerDelegateViews::GetModalType() const {
- return ui::MODAL_TYPE_CHILD;
+ return ui::MODAL_TYPE_WINDOW;
}
bool SigninViewControllerDelegateViews::ShouldShowCloseButton() const {
@@ -107,9 +107,12 @@ void SigninViewControllerDelegateViews::ResizeNativeView(int height) {
}
void SigninViewControllerDelegateViews::DisplayModal() {
- modal_signin_widget_ = constrained_window::ShowWebModalDialogViews(
- this, browser_->tab_strip_model()->GetActiveWebContents());
- content_view_->RequestFocus();
+ gfx::NativeWindow window = browser_->tab_strip_model()
+ ->GetActiveWebContents()
+ ->GetTopLevelNativeWindow();
+ modal_signin_widget_ =
+ constrained_window::CreateBrowserModalDialogViews(this, window);
+ modal_signin_widget_->Show();
}
// static
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698