Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2600473002: Remove the temporary flag to disable the sync confirmation page. (Closed)

Created:
4 years ago by msarda
Modified:
4 years ago
Reviewers:
anthonyvd
CC:
chromium-reviews, sync-reviews_chromium.org, tfarina, zmin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the temporary flag to disable the sync confirmation page. This CL removes the temporary hack to disable the sync confirmaton page as the sync confirmation dialog is browser modal and thus it is no longer dismissed on page navigation BUG=657924 Committed: https://crrev.com/693b76e2b6c18a668f14df50316548214e316663 Cr-Commit-Position: refs/heads/master@{#440528}

Patch Set 1 #

Patch Set 2 : Fix upstream branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/browser/ui/sync/one_click_signin_sync_starter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 3 chunks +0 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
msarda
Please take a look.
4 years ago (2016-12-22 10:56:37 UTC) #2
anthonyvd
lgtm
4 years ago (2016-12-22 18:04:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600473002/20001
4 years ago (2016-12-22 21:45:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-22 22:36:23 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-22 22:40:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/693b76e2b6c18a668f14df50316548214e316663
Cr-Commit-Position: refs/heads/master@{#440528}

Powered by Google App Engine
This is Rietveld 408576698