Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2593833002: Constrain transform animation direct compositing reason to transforms. (Closed)

Created:
4 years ago by wkorman
Modified:
4 years ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chrishtr, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Constrain transform animation direct compositing reason to transforms. Only affects SPv2 code path. Follow-up to http://crrev.com/2578343002 which was overly broad in considering animation state. BUG=674317 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/03fe8f6efab3e8e3cc7833c8a7534d2c633bb308 Cr-Commit-Position: refs/heads/master@{#440215}

Patch Set 1 #

Patch Set 2 : EXPECT not ASSERT. #

Total comments: 2

Patch Set 3 : Add test. #

Total comments: 2

Patch Set 4 : Shift tests. #

Messages

Total messages: 25 (14 generated)
wkorman
4 years ago (2016-12-20 21:22:16 UTC) #3
wkorman
s/chrishtr/pdr/
4 years ago (2016-12-20 21:34:17 UTC) #7
pdr.
https://codereview.chromium.org/2593833002/diff/20001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp (right): https://codereview.chromium.org/2593833002/diff/20001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp#newcode424 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:424: Element* target = document().getElementById("target"); Can you add a test ...
4 years ago (2016-12-21 00:02:24 UTC) #10
wkorman
https://codereview.chromium.org/2593833002/diff/20001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp (right): https://codereview.chromium.org/2593833002/diff/20001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp#newcode424 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:424: Element* target = document().getElementById("target"); On 2016/12/21 at 00:02:24, pdr ...
4 years ago (2016-12-21 18:58:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593833002/40001
4 years ago (2016-12-21 18:59:18 UTC) #13
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-21 18:59:20 UTC) #15
pdr.
LGTM https://codereview.chromium.org/2593833002/diff/40001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp (right): https://codereview.chromium.org/2593833002/diff/40001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp#newcode424 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:424: TransformNodeWithAnimationLosesNodeWhenAnimationRemoved) { Nit: can you move this test ...
4 years ago (2016-12-21 19:00:06 UTC) #16
wkorman
https://codereview.chromium.org/2593833002/diff/40001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp (right): https://codereview.chromium.org/2593833002/diff/40001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp#newcode424 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:424: TransformNodeWithAnimationLosesNodeWhenAnimationRemoved) { On 2016/12/21 at 19:00:06, pdr (OOO Dec ...
4 years ago (2016-12-21 19:20:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593833002/60001
4 years ago (2016-12-21 19:21:32 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-21 21:18:27 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-21 21:22:13 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/03fe8f6efab3e8e3cc7833c8a7534d2c633bb308
Cr-Commit-Position: refs/heads/master@{#440215}

Powered by Google App Engine
This is Rietveld 408576698