Constrain transform animation direct compositing reason to transforms.

Constrain transform animation direct compositing reason to transforms.

Only affects SPv2 code path. Follow-up to http://crrev.com/2578343002
which was overly broad in considering animation state.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/03fe8f6efab3e8e3cc7833c8a7534d2c633bb308
Cr-Commit-Position: refs/heads/master@{#440215}

[wkorman, 2016-12-20 21:21:40]

Description was changed from

==========
Constrain transform animation direct compositing reason to transforms.

Only affects SPv2 code path. Follow-up to http://crrev.com/2578343002
which was overly broad in considering animation state.

BUG=674317
==========

to

==========
Constrain transform animation direct compositing reason to transforms.

Only affects SPv2 code path. Follow-up to http://crrev.com/2578343002
which was overly broad in considering animation state.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2016-12-20 21:22:15]

wkorman@chromium.org changed reviewers:
+ chrishtr@chromium.org

[wkorman, 2016-12-20 21:26:38]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 21:27:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2016-12-20 21:34:15]

wkorman@chromium.org changed reviewers:
+ pdr@chromium.org
- chrishtr@chromium.org

[wkorman, 2016-12-20 21:34:17]

s/chrishtr/pdr/

[commit-bot: I haz the power, 2016-12-20 22:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:57:39]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-12-21 00:02:24]

https://codereview.chromium.org/2593833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
(right):

https://codereview.chromium.org/2593833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:424:
Element* target = document().getElementById("target");
Can you add a test to PaintPropertyTreeUpdateTests.cpp where we remove the
animation and ensure the transform is removed?

[wkorman, 2016-12-21 18:58:49]

https://codereview.chromium.org/2593833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
(right):

https://codereview.chromium.org/2593833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:424:
Element* target = document().getElementById("target");
On 2016/12/21 at 00:02:24, pdr (OOO Dec 23 to Jan 2) wrote:
> Can you add a test to PaintPropertyTreeUpdateTests.cpp where we remove the
animation and ensure the transform is removed?

Done.

[wkorman, 2016-12-21 18:58:51]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:59:20]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pdr., 2016-12-21 19:00:06]

LGTM

https://codereview.chromium.org/2593833002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
(right):

https://codereview.chromium.org/2593833002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:424:
TransformNodeWithAnimationLosesNodeWhenAnimationRemoved) {
Nit: can you move this test to PaintPropertyTreeUpdateTests?

[wkorman, 2016-12-21 19:20:54]

https://codereview.chromium.org/2593833002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
(right):

https://codereview.chromium.org/2593833002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:424:
TransformNodeWithAnimationLosesNodeWhenAnimationRemoved) {
On 2016/12/21 at 19:00:06, pdr (OOO Dec 23 to Jan 2) wrote:
> Nit: can you move this test to PaintPropertyTreeUpdateTests?

Done.

[wkorman, 2016-12-21 19:21:00]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2016-12-21 19:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2593833002/#ps60001
(title: "Shift tests.")

[commit-bot: I haz the power, 2016-12-21 19:21:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:17:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482348060557910,
"parent_rev": "9af1192cd77a2811d6a7c6cf8ec3e018be31570c", "commit_rev":
"bf8b4d522464523775e3bb7202da4600cd5e155c"}

[commit-bot: I haz the power, 2016-12-21 21:18:26]

Description was changed from

==========
Constrain transform animation direct compositing reason to transforms.

Only affects SPv2 code path. Follow-up to http://crrev.com/2578343002
which was overly broad in considering animation state.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Constrain transform animation direct compositing reason to transforms.

Only affects SPv2 code path. Follow-up to http://crrev.com/2578343002
which was overly broad in considering animation state.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2593833002
==========

[commit-bot: I haz the power, 2016-12-21 21:18:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-21 21:22:12]

Description was changed from

==========
Constrain transform animation direct compositing reason to transforms.

Only affects SPv2 code path. Follow-up to http://crrev.com/2578343002
which was overly broad in considering animation state.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2593833002
==========

to

==========
Constrain transform animation direct compositing reason to transforms.

Only affects SPv2 code path. Follow-up to http://crrev.com/2578343002
which was overly broad in considering animation state.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/03fe8f6efab3e8e3cc7833c8a7534d2c633bb308
Cr-Commit-Position: refs/heads/master@{#440215}
==========

[commit-bot: I haz the power, 2016-12-21 21:22:13]

Patchset 4 (id:??) landed as
https://crrev.com/03fe8f6efab3e8e3cc7833c8a7534d2c633bb308
Cr-Commit-Position: refs/heads/master@{#440215}