Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp

Issue 2593833002: Constrain transform animation direct compositing reason to transforms. (Closed)
Patch Set: Shift tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp
index e4413f3085978014307c825c4b7ddd625fe09be4..0945dd32694c5bbc99e6f8e6707b0ef4d611e6f9 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp
@@ -159,4 +159,56 @@ TEST_F(CompositingReasonFinderTest, OnlyOpaqueFixedLayersPromoted) {
ASSERT_TRUE(paintLayer);
EXPECT_EQ(NotComposited, paintLayer->compositingState());
}
+
+TEST_F(CompositingReasonFinderTest, RequiresCompositingForTransformAnimation) {
+ RefPtr<ComputedStyle> style = ComputedStyle::create();
+ style->setSubtreeWillChangeContents(false);
+
+ style->setHasCurrentTransformAnimation(false);
+ style->setIsRunningTransformAnimationOnCompositor(false);
+ EXPECT_FALSE(
+ CompositingReasonFinder::requiresCompositingForTransformAnimation(
+ *style));
+
+ style->setHasCurrentTransformAnimation(false);
+ style->setIsRunningTransformAnimationOnCompositor(true);
+ EXPECT_FALSE(
+ CompositingReasonFinder::requiresCompositingForTransformAnimation(
+ *style));
+
+ style->setHasCurrentTransformAnimation(true);
+ style->setIsRunningTransformAnimationOnCompositor(false);
+ EXPECT_TRUE(CompositingReasonFinder::requiresCompositingForTransformAnimation(
+ *style));
+
+ style->setHasCurrentTransformAnimation(true);
+ style->setIsRunningTransformAnimationOnCompositor(true);
+ EXPECT_TRUE(CompositingReasonFinder::requiresCompositingForTransformAnimation(
+ *style));
+
+ style->setSubtreeWillChangeContents(true);
+
+ style->setHasCurrentTransformAnimation(false);
+ style->setIsRunningTransformAnimationOnCompositor(false);
+ EXPECT_FALSE(
+ CompositingReasonFinder::requiresCompositingForTransformAnimation(
+ *style));
+
+ style->setHasCurrentTransformAnimation(false);
+ style->setIsRunningTransformAnimationOnCompositor(true);
+ EXPECT_TRUE(CompositingReasonFinder::requiresCompositingForTransformAnimation(
+ *style));
+
+ style->setHasCurrentTransformAnimation(true);
+ style->setIsRunningTransformAnimationOnCompositor(false);
+ EXPECT_FALSE(
+ CompositingReasonFinder::requiresCompositingForTransformAnimation(
+ *style));
+
+ style->setHasCurrentTransformAnimation(true);
+ style->setIsRunningTransformAnimationOnCompositor(true);
+ EXPECT_TRUE(CompositingReasonFinder::requiresCompositingForTransformAnimation(
+ *style));
}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698