Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2593833002: Constrain transform animation direct compositing reason to transforms. (Closed)
Patch Set: Shift tests. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/compositing/CompositingReasonFinder.h" 5 #include "core/layout/compositing/CompositingReasonFinder.h"
6 6
7 #include "core/CSSPropertyNames.h" 7 #include "core/CSSPropertyNames.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/frame/FrameView.h" 9 #include "core/frame/FrameView.h"
10 #include "core/frame/Settings.h" 10 #include "core/frame/Settings.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 } 171 }
172 172
173 bool CompositingReasonFinder::requiresCompositingForAnimation( 173 bool CompositingReasonFinder::requiresCompositingForAnimation(
174 const ComputedStyle& style) { 174 const ComputedStyle& style) {
175 if (style.subtreeWillChangeContents()) 175 if (style.subtreeWillChangeContents())
176 return style.isRunningAnimationOnCompositor(); 176 return style.isRunningAnimationOnCompositor();
177 177
178 return style.shouldCompositeForCurrentAnimations(); 178 return style.shouldCompositeForCurrentAnimations();
179 } 179 }
180 180
181 bool CompositingReasonFinder::requiresCompositingForTransformAnimation(
182 const ComputedStyle& style) {
183 return style.subtreeWillChangeContents()
184 ? style.isRunningTransformAnimationOnCompositor()
185 : style.hasCurrentTransformAnimation();
186 }
187
181 bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition( 188 bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition(
182 const PaintLayer* layer) const { 189 const PaintLayer* layer) const {
183 if (layer->layoutObject()->style()->position() != FixedPosition && 190 if (layer->layoutObject()->style()->position() != FixedPosition &&
184 layer->layoutObject()->style()->position() != StickyPosition) 191 layer->layoutObject()->style()->position() != StickyPosition)
185 return false; 192 return false;
186 193
187 if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) && 194 if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) &&
188 (!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() || 195 (!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() ||
189 !layer->backgroundIsKnownToBeOpaqueInRect( 196 !layer->backgroundIsKnownToBeOpaqueInRect(
190 LayoutRect(layer->boundingBoxForCompositing())) || 197 LayoutRect(layer->boundingBoxForCompositing())) ||
191 layer->compositesWithTransform() || layer->compositesWithOpacity())) { 198 layer->compositesWithTransform() || layer->compositesWithOpacity())) {
192 return false; 199 return false;
193 } 200 }
194 // Don't promote fixed position elements that are descendants of a non-view 201 // Don't promote fixed position elements that are descendants of a non-view
195 // container, e.g. transformed elements. They will stay fixed wrt the 202 // container, e.g. transformed elements. They will stay fixed wrt the
196 // container rather than the enclosing frame. 203 // container rather than the enclosing frame.
197 if (layer->sticksToViewport()) 204 if (layer->sticksToViewport())
198 return m_layoutView.frameView()->isScrollable(); 205 return m_layoutView.frameView()->isScrollable();
199 return layer->layoutObject()->style()->position() == StickyPosition && 206 return layer->layoutObject()->style()->position() == StickyPosition &&
200 layer->ancestorOverflowLayer()->scrollsOverflow(); 207 layer->ancestorOverflowLayer()->scrollsOverflow();
201 } 208 }
202 209
203 } // namespace blink 210 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698