[Cronet] set use_partition_alloc to false in Cronet recipes

[Cronet] set use_partition_alloc to false in Cronet recipes

BUG=674570
Review-Url: https://codereview.chromium.org/2593683002
Committed: https://chromium.googlesource.com/chromium/tools/build/+/33c5e23d1949c433885abd3884719d67988c1f98

[xunjieli, 2016-12-20 16:44:55]

xunjieli@chromium.org changed reviewers:
+ jbudorick@chromium.org

[xunjieli, 2016-12-20 16:45:02]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 16:45:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 16:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 16:50:37]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3335f4a2460ba410)

[jbudorick, 2016-12-20 16:51:56]

lgtm

https://codereview.chromium.org/2593683002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/chromium_config.py (right):

https://codereview.chromium.org/2593683002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/chromium_config.py:81:
c.gyp_env.GYP_DEFINES['use_partition_alloc'] = 0
I think we can get rid of the GYP_DEFINES now, but I'm fine with doing so in a
separate CL.

[xunjieli, 2016-12-20 17:29:07]

Thanks!

https://codereview.chromium.org/2593683002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/chromium_config.py (right):

https://codereview.chromium.org/2593683002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/chromium_config.py:81:
c.gyp_env.GYP_DEFINES['use_partition_alloc'] = 0
On 2016/12/20 16:51:56, jbudorick wrote:
> I think we can get rid of the GYP_DEFINES now, but I'm fine with doing so in a
> separate CL.

Done.

[xunjieli, 2016-12-20 17:29:11]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-12-20 17:29:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2593683002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-12-20 17:29:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 17:34:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 17:34:53]

Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/33361d39326a7c10)

[xunjieli, 2016-12-20 17:40:23]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-12-20 17:40:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2593683002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-20 17:40:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 17:44:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482255623932560,
"parent_rev": "84459e33f8c74461ed25577750088844d93ed5a6", "commit_rev":
"33c5e23d1949c433885abd3884719d67988c1f98"}

[commit-bot: I haz the power, 2016-12-20 17:44:56]

Description was changed from

==========
[Cronet] set use_partition_alloc to false in Cronet recipes

BUG=674570
==========

to

==========
[Cronet] set use_partition_alloc to false in Cronet recipes

BUG=674570

Review-Url: https://codereview.chromium.org/2593683002
Committed:
https://chromium.googlesource.com/chromium/tools/build/+/33c5e23d1949c433885a...
==========

[commit-bot: I haz the power, 2016-12-20 17:44:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/33c5e23d1949c433885a...