Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: scripts/slave/recipe_modules/chromium_android/chromium_config.py

Issue 2593683002: [Cronet] set use_partition_alloc to false in Cronet recipes (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/cronet/example.expected/gn_test.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.config_types import Path 5 from recipe_engine.config_types import Path
6 from recipe_engine import config as recipe_config 6 from recipe_engine import config as recipe_config
7 7
8 import DEPS 8 import DEPS
9 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX 9 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX
10 10
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 def dartium_builder(c): 71 def dartium_builder(c):
72 c.compile_py.default_targets=['chrome_apk', 'content_shell_apk'] 72 c.compile_py.default_targets=['chrome_apk', 'content_shell_apk']
73 73
74 @CONFIG_CTX(includes=['clobber']) 74 @CONFIG_CTX(includes=['clobber'])
75 def cronet_builder(c): 75 def cronet_builder(c):
76 c.gyp_env.GYP_DEFINES['disable_brotli_filter'] = 1 76 c.gyp_env.GYP_DEFINES['disable_brotli_filter'] = 1
77 c.gyp_env.GYP_DEFINES['disable_file_support'] = 1 77 c.gyp_env.GYP_DEFINES['disable_file_support'] = 1
78 c.gyp_env.GYP_DEFINES['disable_ftp_support'] = 1 78 c.gyp_env.GYP_DEFINES['disable_ftp_support'] = 1
79 c.gyp_env.GYP_DEFINES['enable_websockets'] = 0 79 c.gyp_env.GYP_DEFINES['enable_websockets'] = 0
80 c.gyp_env.GYP_DEFINES['use_platform_icu_alternatives'] = 1 80 c.gyp_env.GYP_DEFINES['use_platform_icu_alternatives'] = 1
81 c.gyp_env.GYP_DEFINES['use_partition_alloc'] = 0
jbudorick 2016/12/20 16:51:56 I think we can get rid of the GYP_DEFINES now, but
xunjieli 2016/12/20 17:29:07 Done.
81 c.gn_args.append('disable_brotli_filter=true') 82 c.gn_args.append('disable_brotli_filter=true')
82 c.gn_args.append('disable_file_support=true') 83 c.gn_args.append('disable_file_support=true')
83 c.gn_args.append('disable_ftp_support=true') 84 c.gn_args.append('disable_ftp_support=true')
84 c.gn_args.append('enable_websockets=false') 85 c.gn_args.append('enable_websockets=false')
85 c.gn_args.append('use_platform_icu_alternatives=true') 86 c.gn_args.append('use_platform_icu_alternatives=true')
87 c.gn_args.append('use_partition_alloc=false')
86 # TODO(jbudorick): Remove {cronet,net}_unittests_apk targets after 88 # TODO(jbudorick): Remove {cronet,net}_unittests_apk targets after
87 # gn switch is finished. 89 # gn switch is finished.
88 c.compile_py.default_targets=['cronet_package', 90 c.compile_py.default_targets=['cronet_package',
89 'cronet_perf_test_apk', 91 'cronet_perf_test_apk',
90 'cronet_sample_test_apk', 92 'cronet_sample_test_apk',
91 'cronet_test_instrumentation_apk', 93 'cronet_test_instrumentation_apk',
92 'cronet_unittests', 94 'cronet_unittests',
93 'cronet_unittests_apk', 95 'cronet_unittests_apk',
94 'net_unittests', 96 'net_unittests',
95 'net_unittests_apk',] 97 'net_unittests_apk',]
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 c.gyp_env.GYP_DEFINES['chromecast'] = 1 204 c.gyp_env.GYP_DEFINES['chromecast'] = 1
203 205
204 @CONFIG_CTX() 206 @CONFIG_CTX()
205 def disable_neon(c): # pragma: no cover 207 def disable_neon(c): # pragma: no cover
206 c.gn_args.append('arm_use_neon=false') 208 c.gn_args.append('arm_use_neon=false')
207 c.gyp_env.GYP_DEFINES['arm_neon'] = 0 209 c.gyp_env.GYP_DEFINES['arm_neon'] = 0
208 210
209 @CONFIG_CTX() 211 @CONFIG_CTX()
210 def errorprone(c): 212 def errorprone(c):
211 c.gyp_env.GYP_DEFINES['enable_errorprone'] = 1 213 c.gyp_env.GYP_DEFINES['enable_errorprone'] = 1
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/cronet/example.expected/gn_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698