Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: scripts/slave/recipe_modules/chromium_android/chromium_config.py

Issue 2593683002: [Cronet] set use_partition_alloc to false in Cronet recipes (Closed)
Patch Set: Rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/cronet/example.expected/gn_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/chromium_config.py
diff --git a/scripts/slave/recipe_modules/chromium_android/chromium_config.py b/scripts/slave/recipe_modules/chromium_android/chromium_config.py
index a8a132ab55ca467f0fdf9b1c2c9e119f57a2cc2a..7d03c24f55343ec45d4c2ed5dddb5c0365cb6420 100644
--- a/scripts/slave/recipe_modules/chromium_android/chromium_config.py
+++ b/scripts/slave/recipe_modules/chromium_android/chromium_config.py
@@ -69,16 +69,12 @@ def mipsel_builder_mb(c):
@CONFIG_CTX(includes=['clobber'])
def cronet_builder(c):
- c.gyp_env.GYP_DEFINES['disable_brotli_filter'] = 1
- c.gyp_env.GYP_DEFINES['disable_file_support'] = 1
- c.gyp_env.GYP_DEFINES['disable_ftp_support'] = 1
- c.gyp_env.GYP_DEFINES['enable_websockets'] = 0
- c.gyp_env.GYP_DEFINES['use_platform_icu_alternatives'] = 1
c.gn_args.append('disable_brotli_filter=true')
c.gn_args.append('disable_file_support=true')
c.gn_args.append('disable_ftp_support=true')
c.gn_args.append('enable_websockets=false')
c.gn_args.append('use_platform_icu_alternatives=true')
+ c.gn_args.append('use_partition_alloc=false')
# TODO(jbudorick): Remove {cronet,net}_unittests_apk targets after
# gn switch is finished.
c.compile_py.default_targets=['cronet_package',
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/cronet/example.expected/gn_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698