Remove ChromeBrowserProvider::SetUIViewAlphaWithAnimation().

Remove ChromeBrowserProvider::SetUIViewAlphaWithAnimation().

There is only one client of that code, so inline the implementation
in infobar_container_ios.mm and remove the indirection.

BUG=676278
Committed: https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb
Cr-Commit-Position: refs/heads/master@{#441144}

[sdefresne, 2016-12-21 18:48:23]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-12-21 18:48:35]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2016-12-21 18:48:35]

Please take a look.

[commit-bot: I haz the power, 2016-12-21 18:48:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:57:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[sdefresne, 2017-01-03 12:41:43]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 12:41:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-03 12:42:15]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-03 12:43:00]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[commit-bot: I haz the power, 2017-01-03 12:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 12:44:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[rohitrao (ping after 24h), 2017-01-03 13:57:11]

lgtm

[sdefresne, 2017-01-03 15:09:14]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 15:09:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 15:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 15:16:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sdefresne, 2017-01-03 15:25:39]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 15:25:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-03 16:07:09]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2017-01-03 16:07:13]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-01-03 16:07:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2593103002/#ps60001
(title: "Restore #include removed by mistake.")

[commit-bot: I haz the power, 2017-01-03 16:07:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 17:20:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483459633020070,
"parent_rev": "665e666ce10e180e0fbed29b57486eff70bb21cf", "commit_rev":
"f37debd11e45d118c4f6c05679d3b824c5b83dd9"}

[commit-bot: I haz the power, 2017-01-03 17:20:29]

Description was changed from

==========
Remove ChromeBrowserProvider::SetUIViewAlphaWithAnimation().

There is only one client of that code, so inline the implementation
in infobar_container_ios.mm and remove the indirection.

BUG=676278
==========

to

==========
Remove ChromeBrowserProvider::SetUIViewAlphaWithAnimation().

There is only one client of that code, so inline the implementation
in infobar_container_ios.mm and remove the indirection.

BUG=676278

Review-Url: https://codereview.chromium.org/2593103002
==========

[commit-bot: I haz the power, 2017-01-03 17:20:30]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2017-01-03 17:24:21]

Description was changed from

==========
Remove ChromeBrowserProvider::SetUIViewAlphaWithAnimation().

There is only one client of that code, so inline the implementation
in infobar_container_ios.mm and remove the indirection.

BUG=676278

Review-Url: https://codereview.chromium.org/2593103002
==========

to

==========
Remove ChromeBrowserProvider::SetUIViewAlphaWithAnimation().

There is only one client of that code, so inline the implementation
in infobar_container_ios.mm and remove the indirection.

BUG=676278

Committed: https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb
Cr-Commit-Position: refs/heads/master@{#441144}
==========

[commit-bot: I haz the power, 2017-01-03 17:24:22]

Patchset 3 (id:??) landed as
https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb
Cr-Commit-Position: refs/heads/master@{#441144}