Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2592113002: Remove legacy InfoBarViewProtocol. (Closed)

Created:
3 years, 12 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, pkl (ping after 24h if needed), vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove legacy InfoBarViewProtocol. The @protocol was only there to allow for upstreaming and can now be removed as client code can directly use @class InfoBarView. BUG=676278 Committed: https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b Cr-Commit-Position: refs/heads/master@{#441128}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -141 lines) Patch
M ios/chrome/browser/infobars/confirm_infobar_controller.mm View 1 3 chunks +4 lines, -7 lines 0 comments Download
M ios/chrome/browser/infobars/confirm_infobar_controller+protected.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/infobars/infobar.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_container_view.mm View 3 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_controller.h View 4 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_controller.mm View 3 chunks +5 lines, -6 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M ios/chrome/browser/passwords/update_password_infobar_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/passwords/update_password_infobar_controller.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/translate/after_translate_infobar_controller.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/translate/before_translate_infobar_controller.mm View 4 chunks +5 lines, -7 lines 0 comments Download
M ios/chrome/browser/translate/never_translate_infobar_controller.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/translate/translate_message_infobar_controller.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/infobars/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/infobars/infobar_view.h View 1 chunk +63 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/infobars/infobar_view.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
D ios/chrome/browser/ui/infobars/infobar_view_protocol.h View 1 chunk +0 lines, -76 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (18 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 12 months ago (2016-12-21 15:01:56 UTC) #4
rohitrao (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-03 14:00:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592113002/60001
3 years, 11 months ago (2017-01-03 14:14:04 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:60001)
3 years, 11 months ago (2017-01-03 15:41:14 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 15:43:51 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b
Cr-Commit-Position: refs/heads/master@{#441128}

Powered by Google App Engine
This is Rietveld 408576698