Convert AudioBufferSource tests using Audit to testharness

Convert AudioBufferSource tests using Audit to testharness

Only the tests using Audit are converted here, using the script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Additional manual changes were needed to replace methods defined by
js-test.  A few tests needed updated expectations due to how
audit-util.js needed to be changed for these tests.



BUG=676355
TEST=

Review-Url: https://codereview.chromium.org/2593043003
Cr-Commit-Position: refs/heads/master@{#442672}
Committed: https://chromium.googlesource.com/chromium/src/+/7f51edaef941956727d65a8f3ac7036684963fbb

[Raymond Toy, 2017-01-03 22:44:53]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 22:45:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 00:20:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 00:20:44]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2017-01-04 19:14:05]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-04 19:14:06]

PTAL

[Raymond Toy, 2017-01-04 19:14:30]

Description was changed from

==========
Convert AudioBufferSource tests to testharness

Only the tests using Audit are converted here, using the script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Additional manual changes were needed to replace methods defined by
js-test.  A few tests needed updated expectations due to how
audit-util.js needed to be changed for these tests.



BUG=676355
TEST=
==========

to

==========
Convert AudioBufferSource tests using Audit to testharness

Only the tests using Audit are converted here, using the script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Additional manual changes were needed to replace methods defined by
js-test.  A few tests needed updated expectations due to how
audit-util.js needed to be changed for these tests.



BUG=676355
TEST=
==========

[hongchan, 2017-01-04 21:47:08]

This CL is using the legacy version of Audit. Is the update to the new version
planned?

[Raymond Toy, 2017-01-05 16:22:34]

On 2017/01/04 at 21:47:08, hongchan wrote:
> This CL is using the legacy version of Audit. Is the update to the new version
planned?

Recall that our goal was to convert (everything) to testharness with minimal
changes,
which means using old Audit.

Conversion to new Audit would happen only after conversion to testharness.

[hongchan, 2017-01-05 23:53:05]

https://codereview.chromium.org/2593043003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt
(right):

https://codereview.chromium.org/2593043003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt:5:
PASS start(when): implicitly play whole buffer from beginning to end .
Where does this [blank+period] come from?

[Raymond Toy, 2017-01-09 21:18:19]

https://codereview.chromium.org/2593043003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt
(right):

https://codereview.chromium.org/2593043003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt:5:
PASS start(when): implicitly play whole buffer from beginning to end .
On 2017/01/05 23:53:05, hongchan wrote:
> Where does this [blank+period] come from?

Good question.  This file shouldn't even be here, I think.
audiobuffersource-start.html isn't part of this CL so the expected file
shouldn't have been modified.

I'll fix this.

[Raymond Toy, 2017-01-09 21:54:11]

https://codereview.chromium.org/2593043003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt
(right):

https://codereview.chromium.org/2593043003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt:5:
PASS start(when): implicitly play whole buffer from beginning to end .
On 2017/01/09 21:18:19, Raymond Toy wrote:
> On 2017/01/05 23:53:05, hongchan wrote:
> > Where does this [blank+period] come from?
> 
> Good question.  This file shouldn't even be here, I think.
> audiobuffersource-start.html isn't part of this CL so the expected file
> shouldn't have been modified.
> 
> I'll fix this.

This is caused by the conversion to Audit in audiobuffersource-testing.js. I've
rearranged the call so that the trailing blank is removed, but this also causes
a leading blank.  Not sure how to fix that short of rewriting everything. If
needed, that should be a separate CL.

[hongchan, 2017-01-10 18:33:13]

On 2017/01/09 21:54:11, Raymond Toy wrote:
>
https://codereview.chromium.org/2593043003/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2593043003/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt:5:
> PASS start(when): implicitly play whole buffer from beginning to end .
> On 2017/01/09 21:18:19, Raymond Toy wrote:
> > On 2017/01/05 23:53:05, hongchan wrote:
> > > Where does this [blank+period] come from?
> > 
> > Good question.  This file shouldn't even be here, I think.
> > audiobuffersource-start.html isn't part of this CL so the expected file
> > shouldn't have been modified.
> > 
> > I'll fix this.
> 
> This is caused by the conversion to Audit in audiobuffersource-testing.js.
I've
> rearranged the call so that the trailing blank is removed, but this also
causes
> a leading blank.  Not sure how to fix that short of rewriting everything. If
> needed, that should be a separate CL.

Agreed. It's not worth it to spend time to fix that. We can remove the bug when
we finally upgrade to the new Audit.

lgtm

[Raymond Toy, 2017-01-10 19:20:38]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-01-10 19:21:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 20:22:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484076038160250,
"parent_rev": "d9293175895d81e0a2b6ca1907347889af268492", "commit_rev":
"7f51edaef941956727d65a8f3ac7036684963fbb"}

[commit-bot: I haz the power, 2017-01-10 20:23:01]

Description was changed from

==========
Convert AudioBufferSource tests using Audit to testharness

Only the tests using Audit are converted here, using the script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Additional manual changes were needed to replace methods defined by
js-test.  A few tests needed updated expectations due to how
audit-util.js needed to be changed for these tests.



BUG=676355
TEST=
==========

to

==========
Convert AudioBufferSource tests using Audit to testharness

Only the tests using Audit are converted here, using the script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Additional manual changes were needed to replace methods defined by
js-test.  A few tests needed updated expectations due to how
audit-util.js needed to be changed for these tests.



BUG=676355
TEST=

Review-Url: https://codereview.chromium.org/2593043003
Cr-Commit-Position: refs/heads/master@{#442672}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f51edaef941956727d65a8f3ac7...
==========

[commit-bot: I haz the power, 2017-01-10 20:23:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7f51edaef941956727d65a8f3ac7...