Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js

Issue 2593043003: Convert AudioBufferSource tests using Audit to testharness (Closed)
Patch Set: Missed a couple testFailed calls. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js
diff --git a/third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js b/third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js
index 2bec418dbe674cb56352033ec8460c59d87f7571..dd48ac0c95b1431f838961406810e53c9b5b384f 100644
--- a/third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js
+++ b/third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js
@@ -45,8 +45,8 @@ function checkSingleTest(renderedBuffer, i) {
renderedArray[j] = renderedData[offsetFrame + j];
var s = description + ": expected: " + expected + " actual: " + renderedArray;
- testFailed(s);
success = false;
+ Should(s, success).beEqualTo(true);
break;
}
}
@@ -60,14 +60,14 @@ function checkSingleTest(renderedBuffer, i) {
renderedArray[j - framesToTest] = renderedData[offsetFrame + j];
var s = description + ": expected: all zeroes actual: " + renderedArray;
- testFailed(s);
success = false;
+ Should(s, success).beEqualTo(true);
break;
}
}
- if (success)
- testPassed(description);
+ Should("", success)
+ .summarize(description, description);
return success;
}
@@ -120,4 +120,4 @@ function createSawtoothWithModulation(context, modTarget, modOffset, modRange) {
lfo.start();
phasor.start();
-}
+}

Powered by Google App Engine
This is Rietveld 408576698