third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html - Issue 2593043003: Convert AudioBufferSource tests using Audit to testharness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html

Issue 2593043003: Convert AudioBufferSource tests using Audit to testharness (Closed)

Patch Set: Missed a couple testFailed calls. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-onended-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html b/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html

index a57cf9d3150f1b260ccafce59cde01782540aee6..fcfc3274c7d72bd3fe283a7c2c4410eb16f1e660 100644

--- a/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html

+++ b/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html

@@ -2,15 +2,14 @@

<html>

<head>

<title>Test premature GC upon OscillatorNode and AudioBufferSourceNode</title>

- <script src="../../resources/js-test.js"></script>

+ <script src="../../resources/testharness.js"></script>

+ <script src="../../resources/testharnessreport.js"></script>

</head>

<body>

- description("Test premature GC upon OscillatorNode and AudioBufferSourceNode");

- window.jsTestIsAsync = true;

var sampleRate = 44100;

var renderDuration = 1;

@@ -39,7 +38,7 @@

// If the node is GCed, |onended| won't be fired. Then this test

// will be timed out because done() will not get called.

node.onended = function () {

- testPassed(sourceNodeType + 'Node 1 survived GC and onended event fired.');

+ Should(sourceNodeType + 'Node 1 survived GC and onended event fired', true).beEqualTo(true);

done();

};

@@ -66,7 +65,6 @@

});

audit.defineTask('finish', function (done) {

- finishJSTest();

done();

});