Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2592593002: Remove the flag to disable Quick View, since it has been released. (Closed)

Created:
4 years ago by oka
Modified:
4 years ago
Reviewers:
fukino
CC:
chromium-reviews, asvitkine+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the flag to disable Quick View, since it has been released. BUG=613465 TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/63b12807e09c485fa25f633cdeda9c043d3c358b Cr-Commit-Position: refs/heads/master@{#439793}

Patch Set 1 #

Patch Set 2 : Format. #

Total comments: 2

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -35 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 1 chunk +10 lines, -17 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
oka
4 years ago (2016-12-20 06:46:23 UTC) #5
oka
PTAL.
4 years ago (2016-12-20 06:46:32 UTC) #6
fukino
https://codereview.chromium.org/2592593002/diff/20001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/2592593002/diff/20001/chrome/browser/about_flags.cc#oldcode2017 chrome/browser/about_flags.cc:2017: {"files-quick-view", IDS_FLAGS_FILES_QUICK_VIEW_NAME, IDS_FLAGS_FILES_QUICK_VIEW_NAME and IDS_FLAGS_FILES_QUICK_VIEW_DESCRIPTION should be removed, too.
4 years ago (2016-12-20 07:38:29 UTC) #8
fukino
4 years ago (2016-12-20 07:38:30 UTC) #9
oka
https://codereview.chromium.org/2592593002/diff/20001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/2592593002/diff/20001/chrome/browser/about_flags.cc#oldcode2017 chrome/browser/about_flags.cc:2017: {"files-quick-view", IDS_FLAGS_FILES_QUICK_VIEW_NAME, On 2016/12/20 07:38:29, fukino wrote: > IDS_FLAGS_FILES_QUICK_VIEW_NAME ...
4 years ago (2016-12-20 08:02:21 UTC) #10
fukino
lgtm
4 years ago (2016-12-20 08:03:10 UTC) #11
commit-bot: I haz the power
This CL has an open dependency (Issue 2589693002 Patch 40001). Please resolve the dependency and ...
4 years ago (2016-12-20 08:13:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592593002/40001
4 years ago (2016-12-20 11:38:34 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-20 14:13:26 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-20 14:15:02 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/63b12807e09c485fa25f633cdeda9c043d3c358b
Cr-Commit-Position: refs/heads/master@{#439793}

Powered by Google App Engine
This is Rietveld 408576698