Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2589693002: Files App: add more performance metrics for foreground initialization. (Closed)

Created:
4 years ago by oka
Modified:
4 years ago
Reviewers:
fukino, jwd
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files App: add more performance metrics for foreground initialization. FileBrowser.Load.ImportElements: Time to initialize the polymer elements. FileBrowser.Load.InitBackgroundPage: Time to initialize the background page. FileBrowser.Load.InitDocuments: Time to initialize the background page and the elements. FileBrowser.Load.InitSettings: Time to restore user settings. FileBrowser.Load.InitUI: Time to initialize all UI after all elements are initialized. BUG=675536 TEST=manually confirmed on Linux that the above values are exported to chrome://histograms. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/574d1b6b15c21078fdb15f2716736a0d4c24ea87 Cr-Commit-Position: refs/heads/master@{#439769}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Move the position of InitBackgroundPage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/elements_importer.js View 1 1 chunk +7 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 4 chunks +11 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 24 (16 generated)
oka
PTAL. jwd@ for histograms.xml
4 years ago (2016-12-19 10:50:49 UTC) #7
oka
4 years ago (2016-12-19 11:24:55 UTC) #8
jwd
lgtm
4 years ago (2016-12-19 16:16:05 UTC) #11
oka
@fukino friendly ping.
4 years ago (2016-12-20 04:35:12 UTC) #12
fukino
lgtm
4 years ago (2016-12-20 04:50:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589693002/40001
4 years ago (2016-12-20 09:19:18 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-20 11:37:51 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-20 11:40:46 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/574d1b6b15c21078fdb15f2716736a0d4c24ea87
Cr-Commit-Position: refs/heads/master@{#439769}

Powered by Google App Engine
This is Rietveld 408576698