Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2589133002: Quick view lazy load part 1: initialize controllers lazily. (Closed)

Created:
4 years ago by oka
Modified:
4 years ago
Reviewers:
oka1, fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick view lazy load part 1: initialize controllers lazily. Initialize MetadataBoxController and QuickViewController only when it is needed. This CL doesn't lazy load polymer element of quick view. It will be done with subsequent CL(s). BUG=675536 TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a91cd206d821a7c61cb04057f4c3bd4da5fe556f Cr-Commit-Position: refs/heads/master@{#439797}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -47 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 2 chunks +4 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata_box_controller.js View 1 2 chunks +24 lines, -17 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 8 chunks +56 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
oka
PTAL.
4 years ago (2016-12-20 08:36:48 UTC) #5
fukino
lgtm
4 years ago (2016-12-20 08:55:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589133002/20001
4 years ago (2016-12-20 14:31:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 14:37:06 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-20 14:40:07 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a91cd206d821a7c61cb04057f4c3bd4da5fe556f
Cr-Commit-Position: refs/heads/master@{#439797}

Powered by Google App Engine
This is Rietveld 408576698