Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 2592483002: [DevTools] Move console viewport to console, rename StaticViewportControl. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
einbinder
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move console viewport to console, rename StaticViewportControl. BUG=none Committed: https://crrev.com/ced25dba6b144662f4b19b30c9da962fd9569164 Cr-Commit-Position: refs/heads/master@{#439596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -846 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/inspector-unit/static-viewport-control.js View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector-unit/static-viewport-control-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control.js View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/console/ConsoleViewport.js View 7 chunks +9 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/StaticViewportControl.js View 1 chunk +0 lines, -169 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js View 5 chunks +51 lines, -542 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
dgozman
Take a look please.
4 years ago (2016-12-19 19:56:37 UTC) #2
einbinder
lgtm
4 years ago (2016-12-19 20:31:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592483002/1
4 years ago (2016-12-19 20:38:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 22:37:25 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-19 22:41:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ced25dba6b144662f4b19b30c9da962fd9569164
Cr-Commit-Position: refs/heads/master@{#439596}

Powered by Google App Engine
This is Rietveld 408576698