third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control.js - Issue 2592483002: [DevTools] Move console viewport to console, rename StaticViewportControl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control.js

Issue 2592483002: [DevTools] Move console viewport to console, rename StaticViewportControl. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-unit/static-viewport-control-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/static-viewport-control.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control.js

similarity index 90%

rename from third_party/WebKit/LayoutTests/http/tests/inspector-unit/static-viewport-control.js

rename to third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control.js

index 0b333830a7b962efd7603716536a6278768d931e..1a0b1fac00aec5da0b8a2276c38a2d65a6ffd945 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/static-viewport-control.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-control.js

@@ -1,4 +1,4 @@

-TestRunner.addResult("This tests if the StaticViewportControl works properly.");

+TestRunner.addResult("This tests if the ViewportControl works properly.");

var items = [];

var heights = [];

@@ -7,7 +7,7 @@ for (var i = 0; i < 100; i++){

items[i].style.height = (heights[i] = (i % 4) ? 50 : 28) + "px";

items[i].textContent = i;

}

-var viewport = new UI.StaticViewportControl({

+var viewport = new UI.ViewportControl({

fastItemHeight: i => heights[i],

itemCount: _ => items.length,

itemElement: i => items[i]