third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js - Issue 2592483002: [DevTools] Move console viewport to console, rename StaticViewportControl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2592483002: [DevTools] Move console viewport to console, rename StaticViewportControl. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/BUILD.gn ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

index 326d8305a31606a8cb97a01872e01c4e7c6998c4..cb7b1fe0ff9107b2a8fe1f7a0d0bacf19acbcc7f 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

@@ -29,7 +29,7 @@

/**

* @implements {UI.Searchable}

* @implements {SDK.TargetManager.Observer}

- * @implements {UI.ViewportControl.Provider}

+ * @implements {Console.ConsoleViewportProvider}

* @unrestricted

Console.ConsoleView = class extends UI.VBox {

@@ -80,7 +80,7 @@ Console.ConsoleView = class extends UI.VBox {

this._filterBar.show(this._contentsElement);

this._filter.addFilters(this._filterBar);

- this._viewport = new UI.ViewportControl(this);

+ this._viewport = new Console.ConsoleViewport(this);

this._viewport.setStickToBottom(true);

this._viewport.contentElement().classList.add('console-group', 'console-group-messages');

this._contentsElement.appendChild(this._viewport.element);

@@ -241,7 +241,7 @@ Console.ConsoleView = class extends UI.VBox {

/**

* @override

* @param {number} index

- * @return {?UI.ViewportElement}

+ * @return {?Console.ConsoleViewportElement}

itemElement(index) {

return this._visibleViewMessages[index];