Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2592293002: Require folks to run `git cl format` on ui/webui/resources (Closed)

Created:
3 years, 12 months ago by Dan Beam
Modified:
3 years, 12 months ago
Reviewers:
dpapad
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Require folks to run `git cl format` on ui/webui/resources R=dpapad@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a1f1c0c03aee7a631d85876e5605dfa40727255d Cr-Commit-Position: refs/heads/master@{#440345}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M ui/webui/resources/PRESUBMIT.py View 2 chunks +9 lines, -2 lines 2 comments Download

Messages

Total messages: 17 (9 generated)
Dan Beam
see also: https://codereview.chromium.org/2597013002
3 years, 12 months ago (2016-12-22 00:12:57 UTC) #2
dpapad
https://codereview.chromium.org/2592293002/diff/1/ui/webui/resources/PRESUBMIT.py File ui/webui/resources/PRESUBMIT.py (right): https://codereview.chromium.org/2592293002/diff/1/ui/webui/resources/PRESUBMIT.py#newcode76 ui/webui/resources/PRESUBMIT.py:76: results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) Can you ensure that this ...
3 years, 12 months ago (2016-12-22 00:59:13 UTC) #7
Dan Beam
https://codereview.chromium.org/2592293002/diff/1/ui/webui/resources/PRESUBMIT.py File ui/webui/resources/PRESUBMIT.py (right): https://codereview.chromium.org/2592293002/diff/1/ui/webui/resources/PRESUBMIT.py#newcode76 ui/webui/resources/PRESUBMIT.py:76: results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) On 2016/12/22 00:59:13, dpapad wrote: ...
3 years, 12 months ago (2016-12-22 00:59:54 UTC) #8
Dan Beam
fwiw: this included crisper files but is not being problematic because of them: https://codereview.chromium.org/2597013002/
3 years, 12 months ago (2016-12-22 03:02:31 UTC) #9
dpapad
lgtm
3 years, 12 months ago (2016-12-22 03:24:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592293002/1
3 years, 12 months ago (2016-12-22 05:08:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-22 05:13:06 UTC) #15
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 05:17:08 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1f1c0c03aee7a631d85876e5605dfa40727255d
Cr-Commit-Position: refs/heads/master@{#440345}

Powered by Google App Engine
This is Rietveld 408576698