|
|
DescriptionRequire folks to run `git cl format` on ui/webui/resources
R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/a1f1c0c03aee7a631d85876e5605dfa40727255d
Cr-Commit-Position: refs/heads/master@{#440345}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (9 generated)
Description was changed from ========== Require folks to run `git cl format` on ui/webui/resources R=dpapad@chromium.org BUG=567770 ========== to ========== Require folks to run `git cl format` on ui/webui/resources R=dpapad@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2592293002/diff/1/ui/webui/resources/PRESUBMI... File ui/webui/resources/PRESUBMIT.py (right): https://codereview.chromium.org/2592293002/diff/1/ui/webui/resources/PRESUBMI... ui/webui/resources/PRESUBMIT.py:76: results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) Can you ensure that this does not create a problem if your patch includes a vulcanized/crispified file? Or if it does, is there an easy way to bypass? I guess this is done only for files under ui/webui/resources (even if the CL has other files too), but it is worth double checking.
https://codereview.chromium.org/2592293002/diff/1/ui/webui/resources/PRESUBMI... File ui/webui/resources/PRESUBMIT.py (right): https://codereview.chromium.org/2592293002/diff/1/ui/webui/resources/PRESUBMI... ui/webui/resources/PRESUBMIT.py:76: results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) On 2016/12/22 00:59:13, dpapad wrote: > Can you ensure that this does not create a problem if your patch includes a > vulcanized/crispified file? Or if it does, is there an easy way to bypass? > > I guess this is done only for files under ui/webui/resources (even if the CL has > other files too), but it is worth double checking. right, there are no crisper files in ui/webui/resources
fwiw: this included crisper files but is not being problematic because of them: https://codereview.chromium.org/2597013002/
lgtm
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1482383267133460, "parent_rev": "52ad667b286cecdf88c75aedd4c71a893b2a181d", "commit_rev": "21b3042cf1f0158319e56e33fd8d81566e4ba96d"}
Message was sent while issue was closed.
Description was changed from ========== Require folks to run `git cl format` on ui/webui/resources R=dpapad@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Require folks to run `git cl format` on ui/webui/resources R=dpapad@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2592293002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Require folks to run `git cl format` on ui/webui/resources R=dpapad@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2592293002 ========== to ========== Require folks to run `git cl format` on ui/webui/resources R=dpapad@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a1f1c0c03aee7a631d85876e5605dfa40727255d Cr-Commit-Position: refs/heads/master@{#440345} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a1f1c0c03aee7a631d85876e5605dfa40727255d Cr-Commit-Position: refs/heads/master@{#440345} |